Skip to content

Commit f30bcb6

Browse files
[pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
1 parent 92134ed commit f30bcb6

File tree

4 files changed

+17
-14
lines changed

4 files changed

+17
-14
lines changed

pylint_django/checkers/__init__.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
from pylint_django.checkers.foreign_key_strings import ForeignKeyStringsChecker
55
from pylint_django.checkers.forms import FormChecker
66
from pylint_django.checkers.json_response import JsonResponseChecker
7+
from pylint_django.checkers.modelfilter_forloop import ModelFilterForLoopChecker
78
from pylint_django.checkers.models import ModelChecker
8-
from pylint_django.checkers.modelfilter_forloop import\
9-
ModelFilterForLoopChecker
109
from pylint_django.checkers.modelsave_forloop import ModelSaveForLoopChecker
11-
from pylint_django.checkers.queryset_iterator import \
12-
QuerysetIteratorForLoopChecker
10+
from pylint_django.checkers.queryset_iterator import QuerysetIteratorForLoopChecker
1311

1412

1513
def register_checkers(linter):

pylint_django/checkers/modelfilter_forloop.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from astroid.nodes import Call, Expr, Attribute
1+
from astroid.nodes import Attribute, Call, Expr
22
from pylint import checkers, interfaces
33
from pylint.checkers import utils
44

@@ -9,7 +9,8 @@ class ModelFilterForLoopChecker(checkers.BaseChecker):
99
"""
1010
Checks for usage of "Model.manager.filter() inside of for loops
1111
"""
12-
__implements__ = (interfaces.IAstroidChecker)
12+
13+
__implements__ = interfaces.IAstroidChecker
1314

1415
name = "model-filter-forloop-checker"
1516

@@ -19,7 +20,7 @@ class ModelFilterForLoopChecker(checkers.BaseChecker):
1920
"consider-using-in-queries",
2021
"Using 'Model.manager.filter()' or 'Model.manager.get() inside a "
2122
"for loop may negatively impact performance. Consider using a "
22-
"single query with as '__in' filter instead, outside of the loop."
23+
"single query with as '__in' filter instead, outside of the loop.",
2324
),
2425
}
2526

pylint_django/checkers/modelsave_forloop.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
from astroid.nodes import Call, Expr, Attribute
1+
from astroid.nodes import Attribute, Call, Expr
22
from pylint import checkers, interfaces
33
from pylint.checkers import utils
44

55
from pylint_django.__pkginfo__ import BASE_ID
6+
67
# from pylint_django.augmentations import is_manager_attribute
78

89

@@ -11,7 +12,8 @@ class ModelSaveForLoopChecker(checkers.BaseChecker):
1112
Checks for usage of Model.manager.create() or Model.save() inside of for
1213
loops
1314
"""
14-
__implements__ = (interfaces.IAstroidChecker)
15+
16+
__implements__ = interfaces.IAstroidChecker
1517

1618
name = "model-save-forloop-checker"
1719

@@ -21,14 +23,14 @@ class ModelSaveForLoopChecker(checkers.BaseChecker):
2123
"consider-using-bulk-create",
2224
"Using 'Model.manager.create()' inside a for loop may negatively "
2325
"impact performance. Consider using 'Model.manager.bulk_create()' "
24-
"instead."
26+
"instead.",
2527
),
2628
f"R{BASE_ID}05": (
2729
"Consider using 'Model.bulk_*()",
2830
"consider-using-bulk-create-save",
2931
"Using 'Model.save()' inside a for loop may negatively impact "
3032
"performance. Consider using 'Model.manager.bulk_update()' or "
31-
"'Model.manager.bulk_create()' instead."
33+
"'Model.manager.bulk_create()' instead.",
3234
),
3335
}
3436

pylint_django/checkers/queryset_iterator.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
from astroid.nodes import Call, Attribute
1+
from astroid.nodes import Attribute, Call
22
from pylint import checkers, interfaces
33
from pylint.checkers import utils
44

55
from pylint_django.__pkginfo__ import BASE_ID
6+
67
# from pylint_django.augmentations import is_manager_attribute
78

89

@@ -11,7 +12,8 @@ class QuerysetIteratorForLoopChecker(checkers.BaseChecker):
1112
Checks for usage of "QuerySet.all()" in the head of a for loop,
1213
eventually suggesting the usage of ".iterator()"
1314
"""
14-
__implements__ = (interfaces.IAstroidChecker)
15+
16+
__implements__ = interfaces.IAstroidChecker
1517

1618
name = "queryset-iterator-forloop-checker"
1719

@@ -21,7 +23,7 @@ class QuerysetIteratorForLoopChecker(checkers.BaseChecker):
2123
"consider-using-queryset-iterator",
2224
"Using 'QuerySet.all()' may load all results in memory "
2325
"if you need to iterate over the data only once and don't need "
24-
"caching, 'QuerySet.iterator()' may be a more performant option."
26+
"caching, 'QuerySet.iterator()' may be a more performant option.",
2527
),
2628
}
2729

0 commit comments

Comments
 (0)