Skip to content

Commit d2853a0

Browse files
committed
Suppress Media class
Fix convention: Invalid class attribute name "js"
1 parent c6a0033 commit d2853a0

File tree

1 file changed

+17
-1
lines changed

1 file changed

+17
-1
lines changed

pylint_django/augmentations/__init__.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from pylint.checkers.base import DocStringChecker
1+
from pylint.checkers.base import DocStringChecker, NameChecker
22
from pylint.checkers.design_analysis import MisdesignChecker
33
from pylint.checkers.classes import ClassChecker
44
from pylint.checkers.newstyle import NewStyleConflictChecker
@@ -156,6 +156,21 @@ def is_model_field_display_method(node):
156156
return False
157157

158158

159+
def is_model_media_valid_attributes(node):
160+
"""Suppress warnings for valid attributes of Media class."""
161+
if node.name not in ('js', ):
162+
return False
163+
164+
parent = node.parent
165+
while parent and not isinstance(parent, ScopedClass):
166+
parent = parent.parent
167+
168+
if parent == None or parent.name != "Media":
169+
return False
170+
171+
return True
172+
173+
159174
def is_class(class_name):
160175
return lambda node: node_is_subclass(node, class_name)
161176

@@ -183,6 +198,7 @@ def apply_augmentations(linter):
183198
suppress_message(linter, MisdesignChecker.leave_class, 'R0903', is_model_meta_subclass)
184199

185200
# Media
201+
suppress_message(linter, NameChecker.visit_assname, 'C0103', is_model_media_valid_attributes)
186202
suppress_message(linter, DocStringChecker.visit_class, 'C0111', is_model_media_subclass)
187203
suppress_message(linter, NewStyleConflictChecker.visit_class, 'C1001', is_model_media_subclass)
188204
suppress_message(linter, ClassChecker.visit_class, 'W0232', is_model_media_subclass)

0 commit comments

Comments
 (0)