Seems like the detection fqname of classes has changed so that with newer versions of pylint/astroid, the class detected is the "replacement" created in the transforms package

Author: carlio

pylint_django/augmentations/__init__.py

@@ -123,9 +123,10 @@ class ModelB(models.Model):
                 pass
             else:
                 for cls in inferred:
-                    if (node_is_subclass(
-                            cls, 'django.db.models.manager.Manager') or
-                            node_is_subclass(cls, 'django.db.models.base.Model')):
+                    if (node_is_subclass(cls,
+                                         'django.db.models.manager.Manager',
+                                         'django.db.models.base.Model',
+                                         '.Model')):
                         # This means that we are looking at a subclass of models.Model
                         # and something is trying to access a <something>_set attribute.
                         # Since this could exist, we will return so as not to raise an
@@ -156,25 +157,31 @@ def is_model_media_subclass(node):
     parents = ('django.contrib.admin.options.ModelAdmin',
                'django.forms.widgets.Media',
                'django.db.models.base.Model',
+               '.Model',  # for the transformed version used in this plugin
                'django.forms.forms.Form',
-               'django.forms.models.ModelForm')
-    return any([node_is_subclass(node.parent, parent) for parent in parents])
+               '.Form',
+               'django.forms.models.ModelForm',
+               '.ModelForm')
+    return node_is_subclass(node.parent, *parents)
 
 
 def is_model_meta_subclass(node):
     """Checks that node is derivative of Meta class."""
     if node.name != 'Meta' or not isinstance(node.parent, Class):
         return False
 
-    parents = ('django.db.models.base.Model',
+    parents = ('.Model',  # for the transformed version used here
+               'django.db.models.base.Model',
+               '.Form',
                'django.forms.forms.Form',
+               '.ModelForm',
                'django.forms.models.ModelForm',
                'rest_framework.serializers.ModelSerializer',
                'rest_framework.generics.GenericAPIView',
                'rest_framework.viewsets.ReadOnlyModelViewSet',
                'rest_framework.viewsets.ModelViewSet',
                'django_filters.filterset.FilterSet',)
-    return any([node_is_subclass(node.parent, parent) for parent in parents])
+    return node_is_subclass(node.parent, *parents)
 
 
 def is_model_mpttmeta_subclass(node):
@@ -183,9 +190,12 @@ def is_model_mpttmeta_subclass(node):
         return False
 
     parents = ('django.db.models.base.Model',
+               '.Model',  # for the transformed version used in this plugin
                'django.forms.forms.Form',
-               'django.forms.models.ModelForm')
-    return any([node_is_subclass(node.parent, parent) for parent in parents])
+               '.Form',
+               'django.forms.models.ModelForm',
+               '.ModelForm')
+    return node_is_subclass(node.parent, *parents)
 
 
 def is_model_test_case_subclass(node):
@@ -233,7 +243,7 @@ def is_model_field_display_method(node):
         # blindly accepting get_*_display
         try:
             for cls in node.last_child().infered():
-                if node_is_subclass(cls, 'django.db.models.base.Model'):
+                if node_is_subclass(cls, 'django.db.models.base.Model', '.Model'):
                     return True
         except InferenceError:
             return False
@@ -354,8 +364,8 @@ def apply_augmentations(linter):
     # For now, just suppress it on models and views
     suppress_message(linter, _leave_class(MisdesignChecker), 'too-few-public-methods',
                      is_class('.Model'))
-    # TODO: why does this not work with the fqn of 'View'? Must be something to do with the overriding and transforms
-    suppress_message(linter, _leave_class(MisdesignChecker), 'too-few-public-methods', is_class('.View'))
+    suppress_message(linter, _leave_class(MisdesignChecker), 'too-few-public-methods',
+                     is_class('.View'))
 
     # Admin
     # Too many public methods (40+/20)

pylint_django/checkers/models.py

@@ -66,7 +66,7 @@ def visit_classdef(self, node):
 
     def _visit_classdef(self, node):
         """Class visitor."""
-        if not node_is_subclass(node, 'django.db.models.base.Model'):
+        if not node_is_subclass(node, 'django.db.models.base.Model', '.Model'):
             # we only care about models
             return
 

pylint_django/utils.py

@@ -5,28 +5,31 @@
 import sys
 
 try:
-    from astroid.util import YES as Unreferable
+    from astroid.bases import YES as Uninferable
 except ImportError:
-    from astroid.util import Unreferable
+    try:
+        from astroid.util import YES as Uninferable
+    except ImportError:
+        from astroid.util import Uninferable
 
 
 PY3 = sys.version_info >= (3, 0)
 
 
-def node_is_subclass(cls, subclass_name):
+def node_is_subclass(cls, *subclass_names):
     """Checks if cls node has parent with subclass_name."""
     if not isinstance(cls, (Class, Instance)):
         return False
 
-    if cls.bases == Unreferable:
+    if cls.bases == Uninferable:
         return False
     for base_cls in cls.bases:
         try:
             for inf in base_cls.infered():
-                if inf.qname() == subclass_name:
+                if inf.qname() in subclass_names:
                     return True
-                if inf != cls and node_is_subclass(inf, subclass_name):
-                    # check up the hierachy in case we are a subclass of
+                if inf != cls and node_is_subclass(inf, *subclass_names):
+                    # check up the hierarchy in case we are a subclass of
                     # a subclass of a subclass ...
                     return True
         except InferenceError:

test/test_func.py

@@ -12,7 +12,7 @@
 
 
 linter.load_plugin_modules(['pylint_django'])
-linter.global_set_option('required-attributes', ())  # remove required __revision__
+
 
 def module_exists(module_name):
     try:
@@ -22,6 +22,7 @@ def module_exists(module_name):
     else:
         return True
 
+
 def tests(input_dir, messages_dir):
     callbacks = [cb_test_gen(LintTestUsingFile)]