BUG: Various inconsistencies in DataFrame getitem/setitem behavior (fixes #2765) #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Will avoid the new PR next time...didn't realize I could force the rebased push without breaking GitHub) |
|
cherry picked this. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2765
Note, to address
__getitem__does not reindex boolean Series key but__setitem__does ", I have changed the__getitem__behavior rather than the__setitem__behavior because it is more consistent with other indexing behavior and does not break any tests...just in case, I have inserted a warning about this happening (which only triggers when a reindex is actually required)Also, in addition to resolving the bugs, I have refactored the code to make
__getitem__and__setitem__code paths as symmetric as possible, in order to help prevent more issues in the future.Unit test coverage added, and performance tests show no impact