Skip to content

API: fillna method argument should be None by default and raise on both ... #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

changhiskhan
Copy link
Contributor

...value and method #2027

@wesm what do you think of the API change? If you're ok with it I'll propagate to DataFrame and Panel.

@wesm
Copy link
Member

wesm commented Nov 27, 2012

I agree that method='ffill' should not be the default. Shouldn't it raise an exception now if you write ts.fillna()? Folks who want that should define TimeSeries.ffill to forward fill for them (we could even add this convenience method). Go ahead and tweak out the other classes-- let me know when ready for merging

@changhiskhan
Copy link
Contributor Author

should be ready to go now.

Added ffill and bfill as convenience functions to Series/DataFrame/Panel

@wesm
Copy link
Member

wesm commented Nov 27, 2012

thank you sir

@wesm wesm closed this Nov 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants