Merge pull request #177 from gliptak/googlequotes

ENH: Implement Google quote functionality

Author: femtotrader

pandas_datareader/data.py

@@ -5,7 +5,7 @@
 import warnings
 
 from pandas_datareader.google.daily import GoogleDailyReader
-from pandas_datareader.google.quotes import _get_data as get_quote_google  # noqa
+from pandas_datareader.google.quotes import GoogleQuotesReader
 
 from pandas_datareader.yahoo.daily import YahooDailyReader
 from pandas_datareader.yahoo.quotes import YahooQuotesReader
@@ -44,6 +44,10 @@ def get_quote_yahoo(*args, **kwargs):
     return YahooQuotesReader(*args, **kwargs).read()
 
 
+def get_quote_google(*args, **kwargs):
+    return GoogleQuotesReader(*args, **kwargs).read()
+
+
 def DataReader(name, data_source=None, start=None, end=None,
                retry_count=3, pause=0.001, session=None):
     """

pandas_datareader/google/quotes.py

@@ -1,10 +1,29 @@
-def _get_data(symbols):
-    """
-    Get current yahoo quote
+import pandas
+from pandas_datareader.base import _BaseReader
+import json
+import re
 
-    (Should) Returns a DataFrame
 
-    ToDo: Not implemented
-    """
-    msg = "Google Finance doesn't have this functionality - can't get quote for %s" % symbols
-    raise NotImplementedError(msg)
+class GoogleQuotesReader(_BaseReader):
+
+    """Get current google quote"""
+
+    @property
+    def url(self):
+        return 'http://www.google.com/finance/info'
+
+    @property
+    def params(self):
+        if isinstance(self.symbols, pandas.compat.string_types):
+            sym_list = self.symbols
+        else:
+            sym_list = ','.join(self.symbols)
+        params = {'q': sym_list}
+        return params
+
+    def _read_lines(self, out):
+        buffer = out.read()
+        m = re.search('// ', buffer)
+        result = json.loads(buffer[m.start() + len('// '):])
+        return pandas.DataFrame(map(lambda x: float(x['l']), result),
+                                index=map(lambda x: x['t'], result))

pandas_datareader/tests/test_data.py

@@ -72,9 +72,9 @@ def test_google(self):
         self.assertRaises(Exception, web.DataReader, "NON EXISTENT TICKER",
                           'google', start, end)
 
-    def test_get_quote_fails(self):
-        self.assertRaises(NotImplementedError, web.get_quote_google,
-                          pd.Series(['GOOG', 'AAPL', 'GOOG']))
+    def test_get_quote_stringlist(self):
+        df = web.get_quote_google(['GOOG', 'AMZN', 'GOOG'])
+        assert_series_equal(df.ix[0], df.ix[2])
 
     def test_get_goog_volume(self):
         for locale in self.locales: