Skip to content

Commit 2f68649

Browse files
gliptakbashtage
authored andcommitted
Skip failing Google tests (#511)
Signed-off-by: Gábor Lipták <[email protected]>
1 parent 561bf49 commit 2f68649

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

pandas_datareader/tests/google/test_google.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from datetime import datetime
99
from pandas_datareader.data import GoogleDailyReader
1010
from pandas_datareader._utils import RemoteDataError, SymbolWarning
11+
from pandas_datareader._testing import skip_on_exception
1112

1213
import requests
1314

@@ -52,6 +53,7 @@ def setup_class(cls):
5253
def teardown_class(cls):
5354
del cls.locales
5455

56+
@skip_on_exception(RemoteDataError)
5557
def test_google(self):
5658
# asserts that google is minimally working and that it throws
5759
# an exception when DataReader can't get a 200 response from
@@ -95,12 +97,14 @@ def test_get_quote_stringlist(self):
9597
tm.assert_index_equal(df.index, pd.Index(['GOOG', 'AMZN', 'GOOG']))
9698
self.assert_option_result(df)
9799

100+
@skip_on_exception(RemoteDataError)
98101
def test_get_goog_volume(self):
99102
for locale in self.locales:
100103
with tm.set_locale(locale):
101104
df = web.get_data_google('GOOG').sort_index()
102105
assert df.Volume.loc['JAN-02-2015'] == 1446662
103106

107+
@skip_on_exception(RemoteDataError)
104108
def test_get_multi1(self):
105109
for locale in self.locales:
106110
sl = ['AAPL', 'AMZN', 'GOOG']
@@ -114,6 +118,7 @@ def test_get_multi1(self):
114118
with pytest.raises(AttributeError):
115119
pan.Close()
116120

121+
@skip_on_exception(RemoteDataError)
117122
def test_get_multi_invalid(self):
118123
with warnings.catch_warnings(record=True):
119124
sl = ['AAPL', 'AMZN', 'INVALID']
@@ -126,6 +131,7 @@ def test_get_multi_all_invalid(self):
126131
with pytest.raises(RemoteDataError):
127132
web.get_data_google(sl, '2012')
128133

134+
@skip_on_exception(RemoteDataError)
129135
def test_get_multi2(self):
130136
with warnings.catch_warnings(record=True) as w:
131137
for locale in self.locales:
@@ -143,6 +149,7 @@ def test_get_multi2(self):
143149
assert result.shape == (4, 3)
144150
assert_n_failed_equals_n_null_columns(w, result)
145151

152+
@skip_on_exception(RemoteDataError)
146153
def test_dtypes(self):
147154
# see gh-3995, gh-8980
148155
data = web.get_data_google(
@@ -155,6 +162,7 @@ def test_dtypes(self):
155162
assert np.issubdtype(data.High.dtype, np.number)
156163
assert np.issubdtype(data.Volume.dtype, np.number)
157164

165+
@skip_on_exception(RemoteDataError)
158166
def test_unicode_date(self):
159167
# see gh-8967
160168
data = web.get_data_google(
@@ -163,6 +171,7 @@ def test_unicode_date(self):
163171
end='JAN-27-13')
164172
assert data.index.name == 'Date'
165173

174+
@skip_on_exception(RemoteDataError)
166175
def test_google_reader_class(self):
167176
r = GoogleDailyReader('GOOG')
168177
df = r.read()

pandas_datareader/tests/test_data.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22

33
from pandas import DataFrame
44
from pandas_datareader.data import DataReader
5+
from pandas_datareader._utils import RemoteDataError
6+
from pandas_datareader._testing import skip_on_exception
57

68

79
class TestDataReader(object):
810

11+
@skip_on_exception(RemoteDataError)
912
def test_read_google(self):
1013
gs = DataReader("GS", "google")
1114
assert isinstance(gs, DataFrame)

0 commit comments

Comments
 (0)