Skip to content

Commit 124b177

Browse files
authored
Update persistent_segment_tree.py
1 parent eaafd1c commit 124b177

File tree

1 file changed

+7
-14
lines changed

1 file changed

+7
-14
lines changed

data_structures/persistent_segment_tree.py

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
from __future__ import annotations
22

3-
43
class Node:
54
def __init__(self, value: int = 0) -> None:
65
self.value: int = value
76
self.left: Node | None = None
87
self.right: Node | None = None
98

10-
119
class PersistentSegmentTree:
1210
def __init__(self, arr: list[int]) -> None:
1311
self.n: int = len(arr)
@@ -78,14 +76,12 @@ def _update(self, node: Node, start: int, end: int, index: int, value: int) -> N
7876

7977
if index <= mid:
8078
new_node.left = self._update(node.left, start, mid, index, value)
81-
new_node.right = node.right
79+
new_node.right = node.right # Ensure right node is the same as the original
8280
else:
83-
new_node.left = node.left
81+
new_node.left = node.left # Ensure left node is the same as the original
8482
new_node.right = self._update(node.right, mid + 1, end, index, value)
8583

86-
new_node.value = (new_node.left.value if new_node.left else 0) + (
87-
new_node.right.value if new_node.right else 0
88-
)
84+
new_node.value = new_node.left.value + (new_node.right.value if new_node.right else 0)
8985

9086
return new_node
9187

@@ -101,7 +97,7 @@ def query(self, version: int, left: int, right: int) -> int:
10197
>>> version_1 = pst.update(0, 1, 5) # Update index 1 to 5
10298
>>> pst.query(version_1, 0, 3) # Sum of all elements in new version
10399
13
104-
>>> pst.query(version_1, 1, 2) # Sum of elements at index 1 and 2 in new version
100+
>>> pst.query(version_1, 1, 2) # Sum of elements at index 1 and 2
105101
8
106102
"""
107103
return self._query(self.roots[version], 0, self.n - 1, left, right)
@@ -119,20 +115,17 @@ def _query(self, node: Node, start: int, end: int, left: int, right: int) -> int
119115
>>> pst._query(root, 0, 3, 2, 3) # Sum of elements at index 2 and 3
120116
7
121117
"""
122-
if left > end or right < start:
118+
if node is None or left > end or right < start:
123119
return 0
124120
if left <= start and right >= end:
125121
return node.value
126122
mid = (start + end) // 2
127-
return self._query(node.left, start, mid, left, right) + self._query(
128-
node.right, mid + 1, end, left, right
129-
)
130-
123+
return (self._query(node.left, start, mid, left, right) +
124+
self._query(node.right, mid + 1, end, left, right))
131125

132126
# Running the doctests
133127
if __name__ == "__main__":
134128
import doctest
135-
136129
print("Running doctests...")
137130
result = doctest.testmod()
138131
print(f"Ran {result.attempted} tests, {result.failed} failed.")

0 commit comments

Comments
 (0)