CI: test for file leakage (pandas-dev#30162)

Author: jbrockmendel

ci/deps/azure-36-locale_slow.yaml

@@ -18,7 +18,7 @@ dependencies:
   - lxml
   - matplotlib=2.2.2
   - numpy=1.14.*
-  - openpyxl=2.4.8
+  - openpyxl=2.5.7
   - python-dateutil
   - python-blosc
   - pytz=2017.2

ci/deps/azure-36-minimum_versions.yaml

@@ -11,14 +11,15 @@ dependencies:
   - pytest-xdist>=1.21
   - hypothesis>=3.58.0
   - pytest-azurepipelines
+  - psutil
 
   # pandas dependencies
   - beautifulsoup4=4.6.0
   - bottleneck=1.2.1
   - jinja2=2.8
   - numexpr=2.6.2
   - numpy=1.13.3
-  - openpyxl=2.4.8
+  - openpyxl=2.5.7
   - pytables=3.4.2
   - python-dateutil=2.6.1
   - pytz=2017.2

doc/source/getting_started/install.rst

@@ -255,7 +255,7 @@ gcsfs                     0.2.2              Google Cloud Storage access
 html5lib                                     HTML parser for read_html (see :ref:`note <optional_html>`)
 lxml                      3.8.0              HTML parser for read_html (see :ref:`note <optional_html>`)
 matplotlib                2.2.2              Visualization
-openpyxl                  2.4.8              Reading / writing for xlsx files
+openpyxl                  2.5.7              Reading / writing for xlsx files
 pandas-gbq                0.8.0              Google Big Query access
 psycopg2                                     PostgreSQL engine for sqlalchemy
 pyarrow                   0.12.0             Parquet, ORC (requires 0.13.0), and feather reading / writing

doc/source/whatsnew/v1.0.0.rst

@@ -424,7 +424,7 @@ Optional libraries below the lowest tested version may still work, but are not c
 +-----------------+-----------------+---------+
 | matplotlib      | 2.2.2           |         |
 +-----------------+-----------------+---------+
-| openpyxl        | 2.4.8           |         |
+| openpyxl        | 2.5.7           |    X    |
 +-----------------+-----------------+---------+
 | pyarrow         | 0.12.0          |    X    |
 +-----------------+-----------------+---------+

pandas/compat/_optional.py

@@ -14,7 +14,7 @@
     "matplotlib": "2.2.2",
     "numexpr": "2.6.2",
     "odfpy": "1.3.0",
-    "openpyxl": "2.4.8",
+    "openpyxl": "2.5.7",
     "pandas_gbq": "0.8.0",
     "pyarrow": "0.12.0",
     "pytables": "3.4.2",

pandas/tests/io/excel/conftest.py

@@ -1,5 +1,7 @@
 import pytest
 
+import pandas.util._test_decorators as td
+
 import pandas.util.testing as tm
 
 from pandas.io.parsers import read_csv
@@ -39,3 +41,25 @@ def read_ext(request):
     Valid extensions for reading Excel files.
     """
     return request.param
+
+
+@pytest.fixture(autouse=True)
+def check_for_file_leaks():
+    """
+    Fixture to run around every test to ensure that we are not leaking files.
+
+    See also
+    --------
+    _test_decorators.check_file_leaks
+    """
+    # GH#30162
+    psutil = td.safe_import("psutil")
+    if not psutil:
+        yield
+
+    else:
+        proc = psutil.Process()
+        flist = proc.open_files()
+        yield
+        flist2 = proc.open_files()
+        assert flist == flist2