log errors to honeycomb (#436)

Author: ichub

apps/passport-server/src/database/queries/historicSemaphore.ts

@@ -63,6 +63,6 @@ function historicRowToGroup(row: QueryResultRow): HistoricSemaphoreGroup {
     groupId: row.groupid,
     rootHash: row.roothash,
     serializedGroup: row.serializedgroup,
-    timeCreated: row.timecreated,
+    timeCreated: row.timecreated
   };
 }

apps/passport-server/src/routing/server.ts

@@ -19,7 +19,7 @@ import { initZuzaluRoutes } from "./routes/zuzaluRoutes";
 
 export async function startServer(
   context: ApplicationContext,
-  globalServices: GlobalServices,
+  globalServices: GlobalServices
 ): Promise<{ app: Application; server: http.Server }> {
   return new Promise<{ app: Application; server: http.Server }>(
     (resolve, reject) => {
@@ -32,16 +32,16 @@ export async function startServer(
 
       app.use(
         express.json({
-          limit: "5mb",
-        }),
+          limit: "5mb"
+        })
       );
       app.use(cors());
       app.use(tracingMiddleware());
       app.use(
         cors({
           origin: "*",
-          methods: ["GET", "POST", "PUT", "DELETE"],
-        }),
+          methods: ["GET", "POST", "PUT", "DELETE"]
+        })
       );
 
       initAllRoutes(app, context, globalServices);
@@ -51,13 +51,13 @@ export async function startServer(
           err: Error,
           req: express.Request,
           res: express.Response,
-          _next: NextFunction,
+          _next: NextFunction
         ) => {
           logger(`[ERROR] ${req.method} ${req.url}`);
           logger(err.stack);
           globalServices.rollbarService?.reportError(err);
           res.status(500).send(err.message);
-        },
+        }
       );
 
       const server = app.listen(port, () => {
@@ -69,14 +69,14 @@ export async function startServer(
       server.on("error", (e: Error) => {
         reject(e);
       });
-    },
+    }
   );
 }
 
 function initAllRoutes(
   app: express.Application,
   context: ApplicationContext,
-  globalServices: GlobalServices,
+  globalServices: GlobalServices
 ): void {
   initStatusRoutes(app, context, globalServices);
   initHealthcheckRoutes(app, context);

apps/passport-server/src/services/devconnectPretixSyncService.ts

@@ -33,7 +33,7 @@ import { pretixTicketsDifferent } from "../util/devconnectTicket";
 import { logger } from "../util/logger";
 import { RollbarService } from "./rollbarService";
 import { SemaphoreService } from "./semaphoreService";
-import { traced } from "./telemetryService";
+import { setError, traced } from "./telemetryService";
 
 const NAME = "Devconnect Pretix";
 
@@ -153,7 +153,7 @@ export class DevconnectPretixSyncService {
           "[DEVCONNECT PRETIX] Failed to save tickets for one or more events",
           e
         );
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         this.rollbarService?.reportError(e);
       }
 
@@ -349,7 +349,7 @@ export class DevconnectPretixSyncService {
           `[DEVCONNECT PRETIX] Sync aborted for organizer ${organizer.id} due to errors`,
           e
         );
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         this.rollbarService?.reportError(e);
       }
     });
@@ -395,7 +395,7 @@ export class DevconnectPretixSyncService {
         }
       } catch (e) {
         logger("[DEVCONNECT PRETIX] Sync aborted due to errors", e);
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         this.rollbarService?.reportError(e);
       }
     });
@@ -445,7 +445,7 @@ export class DevconnectPretixSyncService {
           { error: e }
         );
         this.rollbarService?.reportError(e);
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         return false;
       }
 
@@ -580,7 +580,7 @@ export class DevconnectPretixSyncService {
           { error: e }
         );
         this.rollbarService?.reportError(e);
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         return false;
       }
 
@@ -709,7 +709,7 @@ export class DevconnectPretixSyncService {
           { error: e }
         );
         this.rollbarService?.reportError(e);
-        span?.setAttribute("error", e + "");
+        setError(e, span);
         return false;
       }
       return true;

apps/passport-server/src/services/telemetryService.ts

@@ -66,14 +66,29 @@ export async function traced<T>(
     if (process.env.ROLLBAR_ENV_NAME) {
       span.setAttribute("env_name", process.env.ROLLBAR_ENV_NAME);
     }
-    const result = await func(span);
-    if (
-      options == null ||
-      options.autoEndSpan == null ||
-      options.autoEndSpan == true
-    ) {
+    try {
+      const result = await func(span);
+      if (
+        options == null ||
+        options.autoEndSpan == null ||
+        options.autoEndSpan == true
+      ) {
+        span.end();
+      }
+      return result;
+    } catch (e) {
+      setError(e, span);
       span.end();
+      throw e;
     }
-    return result;
   });
 }
+
+export function setError(e: Error | any, span?: Span): void {
+  span?.setAttribute("error", true);
+  span?.setAttribute("error_msg", e + "");
+
+  if (e instanceof Error && e.stack) {
+    span?.setAttribute("error_trace", e.stack);
+  }
+}