Skip to content

Commit 2d0de85

Browse files
author
Julien Pivotto
committed
Use full roundtripper
Signed-off-by: Julien Pivotto <[email protected]>
1 parent 316097c commit 2d0de85

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

config/http_config_test.go

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,10 +1234,8 @@ endpoint_params:
12341234

12351235
func TestOAuth2UserAgent(t *testing.T) {
12361236
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
1237-
if r.URL.Path != "/" {
1238-
if r.Header.Get("User-Agent") != "myuseragent" {
1239-
t.Fatalf("Expected User-Agent header in oauth request to be 'myuseragent', got '%s'", r.Header.Get("User-Agent"))
1240-
}
1237+
if r.Header.Get("User-Agent") != "myuseragent" {
1238+
t.Fatalf("Expected User-Agent header in oauth request to be 'myuseragent', got '%s'", r.Header.Get("User-Agent"))
12411239
}
12421240

12431241
res, _ := json.Marshal(oauth2TestServerResponse{
@@ -1249,18 +1247,19 @@ func TestOAuth2UserAgent(t *testing.T) {
12491247
}))
12501248
defer ts.Close()
12511249

1252-
config := &OAuth2{
1250+
config := DefaultHTTPClientConfig
1251+
config.OAuth2 = &OAuth2{
12531252
ClientID: "1",
12541253
ClientSecret: "2",
12551254
Scopes: []string{"A", "B"},
12561255
EndpointParams: map[string]string{"hi": "hello"},
12571256
TokenURL: fmt.Sprintf("%s/token", ts.URL),
12581257
}
12591258

1260-
opts := defaultHTTPClientOptions
1261-
WithUserAgent("myuseragent")(&opts)
1262-
1263-
rt := NewOAuth2RoundTripper(config, http.DefaultTransport, &opts)
1259+
rt, err := NewRoundTripperFromConfig(config, "test_oauth2", WithUserAgent("myuseragent"))
1260+
if err != nil {
1261+
t.Fatal(err)
1262+
}
12641263

12651264
client := http.Client{
12661265
Transport: rt,

0 commit comments

Comments
 (0)