This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Fix up examples to match documentation. #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) modified + issued are supposed to have accepted values of Date (YYYY-MM-DD) 2) accessLevel lists out Public, Restricted and Private as having capital letters
|
Actually it would be better to have all fields of date type to have time component. |
|
Yes. I actually agree that having the dates include times would be better, but then the documentation should match. |
|
Accepted into the final 1.0 schema being submitted internally for approval. Per the proposal, Modified, Issued, and Temporal will use ISO 8601 of least resolution. Values for accessLevel were changed to lowercase. Will update the examples as soon as the final 1.0 schema gets a final thumbs up. Thanks Will and Dmitry! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this commit is accepted, and the JSON Validator accepts the commit in Issue #6, then the JSON examples in the metadata-resources should pass the validations.
Neither of these changes includes the JSON changes that jpmckinney + myself have been creating issues around, but I'd be happy to update the validator and examples if those are accepted as well.