This repository was archived by the owner on Jun 18, 2024. It is now read-only.
JSON schema corrections #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyword should always be required. This was an oversight in the update on #269
|
Why is keyword mandatory—is that a DCAT thing? It doesn’t seem that is should be mandatory/not nilable. |
|
Thank you @philipashlock! |
|
@smrazgs - it was a decision in the early days of the Project Open Data schema planning since it enables an important and fundamental aspect of organizing. |
|
Only if there is a systematic and uniformly applied controlled vocabulary of keywords, otherwise a tag cloud generated from the titles and text descriptions is pretty much the same? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few things:
keywordwhich should always be required. Allowing it to be null was an oversight in the update on Update single_entry.json #269keywordis at least one character long (prevents empty strings)distributionis used then ensure that bothaccessURLandformatare includedPrimaryITInvestmentUIIas mentioned in Valid example for PrimaryITInvestmentUII #283 and Use a valid example for PrimaryITInvestmentUII #282accessURLandformatas possible fields outside ofdistribution(but can be null)keyworddoesn't have to be unique as discussed in confirm whether duplicate keywords should break validation #288