Apply suggestions from code review

Signed-off-by: Hanno Becker <[email protected]>

Author: hanno-becker

mlkem/native/aarch64/src/rej_uniform_asm_clean.S

@@ -13,7 +13,7 @@
  *                                     16-bit coefficients.
  *              - const uint8_t *buf:  pointer to input buffer
  *                                     (assumed to be uniform random bytes)
- *              - unsigned buflen: length of input buffer in bytes.
+ *              - unsigned buflen:     length of input buffer in bytes.
  *                                     Must be a multiple of 24.
  *
  * Returns number of sampled 16-bit integers (at most MLKEM_N).

mlkem/native/api.h

@@ -314,11 +314,11 @@ __contract__(
  *              uniform random integers mod q
  *
  * Arguments:   - int16_t *r:          pointer to output buffer
- *              - unsigned len:    requested number of 16-bit integers
+ *              - unsigned len:        requested number of 16-bit integers
  *                                     (uniform mod q).
  *              - const uint8_t *buf:  pointer to input buffer
  *                                     (assumed to be uniform random bytes)
- *              - unsigned buflen: length of input buffer in bytes.
+ *              - unsigned buflen:     length of input buffer in bytes.
  *
  * Return -1 if the native implementation does not support the input lengths.
  * Otherwise, returns non-negative number of sampled 16-bit integers (at most

mlkem/sampling.c

@@ -72,15 +72,15 @@ __contract__(
  *              uniform random integers mod q
  *
  * Arguments:   - int16_t *r:          pointer to output buffer
- *              - unsigned target: requested number of 16-bit integers
+ *              - unsigned target:     requested number of 16-bit integers
  *                                     (uniform mod q).
  *                                     Must be <= 4096.
- *              - unsigned offset: number of 16-bit integers that have
+ *              - unsigned offset:     number of 16-bit integers that have
  *                                     already been sampled.
  *                                     Must be <= target.
  *              - const uint8_t *buf:  pointer to input buffer
  *                                     (assumed to be uniform random bytes)
- *              - unsigned buflen: length of input buffer in bytes
+ *              - unsigned buflen:     length of input buffer in bytes
  *                                     Must be <= 4096.
  *                                     Must be a multiple of 3.
  *
@@ -240,7 +240,7 @@ void poly_rej_uniform(poly *entry, uint8_t seed[MLKEM_SYMBYTES + 2])
  *
  * Arguments:   - const uint8_t *x: pointer to input byte array
  *
- * Returns 32-bit unsignedeger loaded from x
+ * Returns 32-bit unsigned integer loaded from x
  **************************************************/
 static uint32_t load32_littleendian(const uint8_t x[4])
 {
@@ -288,7 +288,7 @@ void poly_cbd2(poly *r, const uint8_t buf[2 * MLKEM_N / 4])
  *
  * Arguments:   - const uint8_t *x: pointer to input byte array
  *
- * Returns 32-bit unsignedeger loaded from x (most significant byte is zero)
+ * Returns 32-bit unsigned integer loaded from x (most significant byte is zero)
  **************************************************/
 static uint32_t load24_littleendian(const uint8_t x[3])
 {

mlkem/verify.h

@@ -164,7 +164,7 @@ __contract__(ensures(return_value == ((x == 0) ? 0 : 0xFF)))
 
 /*
  * The ct_cmask_neg_i16 function below makes deliberate use of
- * signed to unsignedeger conversion, which is fully defined
+ * signed to unsigned integer conversion, which is fully defined
  * behaviour in C. It is thus safe to disable this warning.
  */
 #ifdef CBMC