Skip to content

Commit 1eeede6

Browse files
committed
chore: cleanup commented test
1 parent f8e2ef2 commit 1eeede6

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

internal/controller/csr_controller_test.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -64,28 +64,6 @@ func TestWrongSignerCsr(t *testing.T) {
6464
assert.False(t, approved)
6565
}
6666

67-
// following test is commented out while the config management for the
68-
// controller hasn't been uniformized func
69-
// TestNonSystemNodeCsrIgnoredWhenBypassed(t *testing.T) {
70-
// csrParams := CsrParams{
71-
// csrName: "csr-non-systemnode",
72-
// ipAddresses: testNodeIpAddresses,
73-
// nodeName: testNodeName,
74-
// dnsName: testNodeName + ".test.ch",
75-
// username: "system:serviceaccount:default:stackgres-operator-init", // https://github.com/postfinance/kubelet-csr-approver/issues/61#issuecomment-1160725935
76-
// }
77-
// csr := createCsr(t, csrParams)
78-
// _, nodeClientSet, _ := createControlPlaneUser(t, csr.Spec.Username, []string{"system:masters"})
79-
80-
// _, err := nodeClientSet.CertificatesV1().CertificateSigningRequests().Create(testContext, &csr, metav1.CreateOptions{})
81-
// require.Nil(t, err, "Could not create the CSR.")
82-
83-
// approved, denied, err := waitCsrApprovalStatus(csr.Name)
84-
// require.Nil(t, err, "Could not retrieve the CSR to check its approval status")
85-
// assert.False(t, denied)
86-
// assert.False(t, approved)
87-
// }
88-
8967
func TestNonMatchingCommonNameUsername(t *testing.T) {
9068
csrParams := CsrParams{
9169
csrName: "csr-non-matching",

0 commit comments

Comments
 (0)