Skip to content

Commit fefa77b

Browse files
kolyshkinpolyfloyd
authored andcommitted
feat: ignore io.EOF from io.ReadAtLeast
See https://pkg.go.dev/io#ReadAtLeast Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 47749f4 commit fefa77b

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

errorlint/allowed.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ func setDefaultAllowedErrors() {
5353
{Err: "io.EOF", Fun: "(*io.SectionReader).Read"},
5454
{Err: "io.EOF", Fun: "(*io.SectionReader).ReadAt"},
5555
{Err: "io.ErrClosedPipe", Fun: "(*io.PipeWriter).Write"},
56+
{Err: "io.EOF", Fun: "io.ReadAtLeast"},
5657
{Err: "io.ErrShortBuffer", Fun: "io.ReadAtLeast"},
5758
{Err: "io.ErrUnexpectedEOF", Fun: "io.ReadAtLeast"},
5859
{Err: "io.EOF", Fun: "io.ReadFull"},

errorlint/testdata/src/allowed/allowed.go

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,15 +106,13 @@ func IoPipeWriterWrite(w *io.PipeWriter) {
106106
}
107107
}
108108

109-
func IoReadAtLeast(r io.Reader) {
109+
func IoReadAtLeast(r io.Reader) error {
110110
var buf [4096]byte
111111
_, err := io.ReadAtLeast(r, buf[:], 8192)
112-
if err == io.ErrShortBuffer {
113-
fmt.Println(err)
114-
}
115-
if err == io.ErrUnexpectedEOF {
116-
fmt.Println(err)
112+
if err == io.ErrShortBuffer || err == io.ErrUnexpectedEOF || err == io.EOF {
113+
return err
117114
}
115+
return nil
118116
}
119117

120118
func IoReadFull(r io.Reader) {

0 commit comments

Comments
 (0)