fix: ignore io.EOF from some more sources

debug/elf.Open and debug/elf.NewFile uses io.ReaderAt and return its
error verbatim.

Added function and methods from io package are documented to return EOF.

Signed-off-by: Kir Kolyshkin <[email protected]>

Author: kolyshkin

errorlint/allowed.go

@@ -35,8 +35,15 @@ var allowedErrors = []struct {
 	{err: "io.EOF", fun: "(*bytes.Reader).ReadString"},
 	// pkg/database/sql
 	{err: "sql.ErrNoRows", fun: "(*database/sql.Row).Scan"},
+	// pkg/debug/elf
+	{err: "io.EOF", fun: "elf.Open"},
+	{err: "io.EOF", fun: "elf.NewFile"},
 	// pkg/io
 	{err: "io.EOF", fun: "(io.Reader).Read"},
+	{err: "io.EOF", fun: "(io.ReaderAt).ReadAt"},
+	{err: "io.EOF", fun: "(*io.LimitedReader).Read"},
+	{err: "io.EOF", fun: "(*io.SectionReader).Read"},
+	{err: "io.EOF", fun: "(*io.SectionReader).ReadAt"},
 	{err: "io.ErrClosedPipe", fun: "(*io.PipeWriter).Write"},
 	{err: "io.ErrShortBuffer", fun: "io.ReadAtLeast"},
 	{err: "io.ErrUnexpectedEOF", fun: "io.ReadAtLeast"},

errorlint/testdata/src/allowed/allowed.go

@@ -4,6 +4,7 @@ import (
 	"archive/tar"
 	"bytes"
 	"database/sql"
+	"debug/elf"
 	"errors"
 	"fmt"
 	"io"
@@ -111,6 +112,48 @@ func IoReadFull(r io.Reader) {
 	}
 }
 
+func IoReaderAt(r io.ReaderAt) {
+	var buf [4096]byte
+	_, err := r.ReadAt(buf[:], 0)
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+}
+
+func IoLimitedReader(r *io.LimitedReader) {
+	var buf [4096]byte
+	_, err := r.Read(buf[:])
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+}
+
+func IoSectionReader(r *io.SectionReader) {
+	var buf [4096]byte
+	_, err := r.Read(buf[:])
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+	_, err = r.ReadAt(buf[:], 0)
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+}
+
+func ElfOpen() {
+	_, err := elf.Open("file")
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+}
+
+func ElfNewFile(r io.ReaderAt) {
+	_, err := elf.NewFile(r)
+	if err == io.EOF {
+		fmt.Println(err)
+	}
+}
+
 func SqlRowScan(db *sql.DB) {
 	var i int
 	row := db.QueryRow(`SELECT 1`)