Skip to content

Commit 24f58bd

Browse files
kolyshkinpolyfloyd
authored andcommitted
feat: add exception for mime.ErrInvalidMediaParameter
It is documented ([1]) that mime.ParseMediaType can return mime.ErrInvalidMediaParameter error, so it's not a bug to perform a direct comparison. [1]: https://pkg.go.dev/mime#ParseMediaType Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent 1f1e448 commit 24f58bd

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

errorlint/allowed.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,8 @@ func setDefaultAllowedErrors() {
5757
{Err: "io.ErrUnexpectedEOF", Fun: "io.ReadAtLeast"},
5858
{Err: "io.EOF", Fun: "io.ReadFull"},
5959
{Err: "io.ErrUnexpectedEOF", Fun: "io.ReadFull"},
60+
// pkg/mime
61+
{Err: "mime.ErrInvalidMediaParameter", Fun: "mime.ParseMediaType"},
6062
// pkg/net/http
6163
{Err: "net/http.ErrServerClosed", Fun: "(*net/http.Server).ListenAndServe"},
6264
{Err: "net/http.ErrServerClosed", Fun: "(*net/http.Server).ListenAndServeTLS"},

errorlint/testdata/src/allowed/allowed.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"errors"
1212
"fmt"
1313
"io"
14+
"mime"
1415
"mime/multipart"
1516
"net/http"
1617
"os"
@@ -283,6 +284,13 @@ func MIMEMultipartReadFrom(r io.Reader, boundary string, maxMemory int64) {
283284
}
284285
}
285286

287+
func MimeParseMediaType(contentType string) {
288+
_, _, err := mime.ParseMediaType(contentType)
289+
if err == mime.ErrInvalidMediaParameter {
290+
fmt.Println(err)
291+
}
292+
}
293+
286294
func SyscallErrors() {
287295
err := syscall.Chmod("/dev/null", 0666)
288296
if err == syscall.EINVAL {

0 commit comments

Comments
 (0)