switch show_goto_trace to use trace_configurationt

In this commit:
- switches goto_trace to use trace_configurationt
- rewrites trace_value to avoid passing 4 different members of the same struct goto_trace_stept by reference
- moves the code that displays source code into show_state_header
- modernises the for loops used in case INPUT and case OUTPUT

Author: polgreen

src/cbmc/all_properties.cpp

@@ -175,9 +175,7 @@ void bmc_all_propertiest::report(const cover_goalst &cover_goals)
           if(g.second.status==goalt::statust::FAILURE)
           {
             result() << "\n" << "Trace for " << g.first << ":" << "\n";
-            show_goto_trace(result(), bmc.ns, g.second.goto_trace,
-                bmc.options.get_signed_int_option("trace-verbosity"),
-                bmc.options.get_bool_option("hex"));
+            show_goto_trace(result(), bmc.ns, g.second.goto_trace);
           }
       }
       result() << eom;

src/cbmc/bmc.cpp

@@ -56,9 +56,7 @@ void bmct::error_trace()
   {
   case ui_message_handlert::uit::PLAIN:
     result() << "Counterexample:" << eom;
-    show_goto_trace(result(), ns, goto_trace,
-        options.get_signed_int_option("trace-verbosity"),
-        options.get_bool_option("hex"));
+    show_goto_trace(result(), ns, goto_trace);
     result() << eom;
     break;