Revert shouldComponentUpdate

Author: dmt0

src/factory.js

@@ -64,25 +64,6 @@ export default function plotComponentFactory(Plotly) {
       this.updatePlotly = this.updatePlotly.bind(this);
     }
 
-    shouldComponentUpdate(nextProps) {
-      // frames *always* changes identity so fall back to check length only :(
-      const numPrevFrames =
-        this.props.frames && this.props.frames.length ? this.props.frames.length : 0;
-      const numNextFrames =
-        nextProps.frames && nextProps.frames.length ? nextProps.frames.length : 0;
-
-      const figureChanged = !(
-        nextProps.layout === this.props.layout &&
-        nextProps.data === this.props.data &&
-        nextProps.config === this.props.config &&
-        numNextFrames === numPrevFrames
-      );
-      const revisionDefined = nextProps.revision !== void 0;
-      const revisionChanged = nextProps.revision !== this.props.revision;
-
-      return figureChanged || (revisionDefined && revisionChanged);
-    }
-
     updatePlotly(
       props,
       shouldInvokeResizeHandler,
@@ -132,6 +113,25 @@ export default function plotComponentFactory(Plotly) {
     componentDidUpdate(nextProps) {
       this.unmounting = false;
 
+      // frames *always* changes identity so fall back to check length only :(
+      const numPrevFrames =
+        this.props.frames && this.props.frames.length ? this.props.frames.length : 0;
+      const numNextFrames =
+        nextProps.frames && nextProps.frames.length ? nextProps.frames.length : 0;
+
+      const figureChanged = !(
+        nextProps.layout === this.props.layout &&
+        nextProps.data === this.props.data &&
+        nextProps.config === this.props.config &&
+        numNextFrames === numPrevFrames
+      );
+      const revisionDefined = nextProps.revision !== void 0;
+      const revisionChanged = nextProps.revision !== this.props.revision;
+
+      if (!figureChanged && (!revisionDefined || (revisionDefined && !revisionChanged))) {
+        return;
+      }
+
       this.updatePlotly(nextProps, false, nextProps.onUpdate, false);
     }