Skip to content

Dev app doesn't work in IE #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmt0 opened this issue Feb 26, 2019 · 6 comments · Fixed by #1172
Closed

Dev app doesn't work in IE #854

dmt0 opened this issue Feb 26, 2019 · 6 comments · Fixed by #1172

Comments

@dmt0
Copy link
Contributor

dmt0 commented Feb 26, 2019

fetch needs to be polyfilled

@VeraZab
Copy link
Contributor

VeraZab commented Feb 26, 2019

and i think the css is not working there too, we're compiling 2 versions of sass, one for IE specifically: https://github.com/plotly/react-chart-editor/blob/master/package.json#L114

@dmt0
Copy link
Contributor Author

dmt0 commented Feb 27, 2019

Yes, it's all those custom properties like var(--sidebar-width) - they're not supported in IE, our tools used to take care of those though. postcss-custom-properties to be specific.

@dmt0
Copy link
Contributor Author

dmt0 commented Feb 27, 2019

Were we ever able to test RCE in IE without embedding it into another project?

@VeraZab
Copy link
Contributor

VeraZab commented Feb 27, 2019

I always was testing from streambed..

@nicolaskruchten
Copy link
Contributor

Did you see this part of the readme? https://github.com/plotly/react-chart-editor#styling-the-defaulteditor--and-the-built-in-components

If the dev/demo apps could work in IE that would be helpful IMO

@chl8725
Copy link

chl8725 commented Jun 15, 2020

Did you see this part of the readme? https://github.com/plotly/react-chart-editor#styling-the-defaulteditor--and-the-built-in-components

If the dev/demo apps could work in IE that would be helpful IMO

I can't display in ie.
But go to the link you said
I found import'react-chart-editor/lib/react-chart-editor.ie.min.css' but there is no react-chart-editor.ie.min.css file
where is the file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants