Skip to content

Commit d81e812

Browse files
committed
Make relationship between overlaying and domain clearer
1 parent c02573b commit d81e812

File tree

4 files changed

+28
-8
lines changed

4 files changed

+28
-8
lines changed

src/components/fields/derived.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,18 @@ export const NumericFraction = connectToContainer(UnconnectedNumericFraction, {
232232
modifyPlotProps: numericFractionModifyPlotProps,
233233
});
234234

235+
export const NumericFractionDomain = connectToContainer(
236+
UnconnectedNumericFraction,
237+
{
238+
modifyPlotProps: (props, context, plotProps) => {
239+
numericFractionModifyPlotProps(props, context, plotProps);
240+
if (context.container.overlaying) {
241+
plotProps.isVisible = null;
242+
}
243+
},
244+
}
245+
);
246+
235247
export const LayoutNumericFraction = connectLayoutToPlot(
236248
connectToContainer(UnconnectedNumericFraction, {
237249
supplyPlotProps: supplyLayoutPlotProps,

src/components/fields/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import {
2727
GeoScope,
2828
HoverInfo,
2929
NumericFraction,
30+
NumericFractionDomain,
3031
PositioningNumeric,
3132
NumericFractionInverse,
3233
LayoutNumericFraction,
@@ -62,6 +63,7 @@ export {
6263
LayoutNumericFraction,
6364
LayoutNumericFractionInverse,
6465
NumericFraction,
66+
NumericFractionDomain,
6567
NumericFractionInverse,
6668
PositioningNumeric,
6769
LineDashSelector,

src/components/index.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ import {
2525
LayoutNumericFraction,
2626
LayoutNumericFractionInverse,
2727
NumericFraction,
28+
NumericFractionDomain,
2829
PositioningNumeric,
2930
NumericFractionInverse,
3031
LineDashSelector,
@@ -92,6 +93,7 @@ export {
9293
HoverInfo,
9394
Info,
9495
NumericFraction,
96+
NumericFractionDomain,
9597
PositioningNumeric,
9698
NumericFractionInverse,
9799
LayoutNumericFraction,

src/default_panels/StyleAxesPanel.js

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
Dropdown,
1010
FontSelector,
1111
Numeric,
12-
NumericFraction,
12+
NumericFractionDomain,
1313
Radio,
1414
TextEditor,
1515
MenuPanel,
@@ -36,18 +36,22 @@ const StyleAxesPanel = ({localize: _}) => (
3636
</AxesFold>
3737

3838
<AxesFold name={_('Layout')}>
39-
<Section name={_('Axis Space')} attr="domain[0]">
40-
<NumericFraction label={_('Start Position')} attr="domain[0]" />
41-
<NumericFraction label={_('End Position')} attr="domain[1]" />
42-
</Section>
43-
44-
<Section name={_('Positioning')}>
45-
<AxisAnchorDropdown label={_('Anchor')} attr="anchor" localize={_} />
39+
<Section name={_('Boundaries')} attr="domain[0]">
4640
<AxisOverlayDropdown
4741
label={_('Overlay')}
4842
attr="overlaying"
4943
localize={_}
5044
/>
45+
<NumericFractionDomain label={_('Start Position')} attr="domain[0]" />
46+
<NumericFractionDomain label={_('End Position')} attr="domain[1]" />
47+
</Section>
48+
49+
<Section name={_('Anchor')}>
50+
<AxisAnchorDropdown
51+
label={_('Anchor To')}
52+
attr="anchor"
53+
localize={_}
54+
/>
5155
<AxisSide label={_('Side')} attr="side" localize={_} />
5256
</Section>
5357
</AxesFold>

0 commit comments

Comments
 (0)