change default behaviour of test-utils deref and simplify tests

Author: bpostlethwaite

src/__tests__/connectTraceToPlot-test.js

@@ -18,7 +18,7 @@ Traces.forEach(Trace => {
   describe(`<${Trace.displayName}>`, () => {
     it('wraps container with fullValue pointing to gd._fullData[i]', () => {
       const wrapper = mount(
-        <Editor {...fixtures.scatter({deref: true})}>
+        <Editor {...fixtures.scatter()}>
           <Trace traceIndex={0}>
             <Numeric label="Marker Size" attr="marker.size" />
           </Trace>
@@ -33,7 +33,7 @@ Traces.forEach(Trace => {
     it('sends updates to gd.data', () => {
       const onUpdate = jest.fn();
       const wrapper = mount(
-        <Editor onUpdate={onUpdate} {...fixtures.scatter({deref: true})}>
+        <Editor onUpdate={onUpdate} {...fixtures.scatter()}>
           <Trace traceIndex={0}>
             <Numeric label="Marker Size" attr="marker.size" />
           </Trace>
@@ -54,7 +54,7 @@ Traces.forEach(Trace => {
     it('automatically computes min and max defaults', () => {
       const onUpdate = jest.fn();
       const wrapper = mount(
-        <Editor onUpdate={onUpdate} {...fixtures.scatter({deref: true})}>
+        <Editor onUpdate={onUpdate} {...fixtures.scatter()}>
           <Trace traceIndex={0}>
             <Numeric label="marker size" attr="marker.size" />
           </Trace>

src/components/containers/__tests__/Section-test.js

@@ -12,7 +12,7 @@ describe('Section', () => {
   it('is visible if it contains any visible children', () => {
     // mode is visible with scatter. Hole is not visible. Section should show.
     const wrapper = mount(
-      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter({deref: true})}>
+      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter()}>
         <TraceSection traceIndex={0} name="test-section">
           <Flaglist
             attr="mode"
@@ -46,7 +46,7 @@ describe('Section', () => {
 
   it('is visible if it contains any non attr children', () => {
     const wrapper = mount(
-      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter({deref: true})}>
+      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter()}>
         <Section name="test-section">
           <Info>INFO</Info>
         </Section>
@@ -61,7 +61,7 @@ describe('Section', () => {
   it('is not visible if it contains no visible children', () => {
     // pull and hole are not scatter attrs. Section should not show.
     const wrapper = mount(
-      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter({deref: true})}>
+      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter()}>
         <TraceSection traceIndex={0} name="test-section">
           <Numeric attr="pull" min={0} max={1} step={0.1} traceIndex={0} />
           <Numeric attr="hole" min={0} max={1} step={0.1} traceIndex={0} />
@@ -81,7 +81,7 @@ describe('Section', () => {
 
   it('will render first menuPanel even with no visible attrs', () => {
     const wrapper = mount(
-      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter({deref: true})}>
+      <TestEditor onUpdate={jest.fn()} {...fixtures.scatter()}>
         <Section name="test-section">
           <MenuPanel show>
             <Info>INFO</Info>

src/components/fields/__tests__/Radio-test.js

@@ -11,7 +11,7 @@ const Trace = connectTraceToPlot(Section);
 describe('<Radio>', () => {
   it('enables <Field> centering by default', () => {
     const wrapper = mount(
-      <TestEditor plotly={plotly} {...fixtures.area({deref: 'true'})}>
+      <TestEditor plotly={plotly} {...fixtures.area()}>
         <Trace traceIndex={0}>
           <Radio
             label="Connect Gaps"
@@ -30,7 +30,7 @@ describe('<Radio>', () => {
 
   it('permits <Field> centering to be disabled', () => {
     const wrapper = mount(
-      <TestEditor plotly={plotly} {...fixtures.area({deref: 'true'})}>
+      <TestEditor plotly={plotly} {...fixtures.area()}>
         <Trace traceIndex={0}>
           <Radio
             center={false}

src/lib/test-utils.js

@@ -65,7 +65,7 @@ function applyConfig(config = {}, {graphDiv: {data, layout}, dataSources}) {
   if (config.data) {
     extendDeep(data, config.data);
   }
-  if (config.deref) {
+  if (config.deref !== false) {
     dereference(data, dataSources);
   }