Skip to content

Commit a0317b5

Browse files
committed
use standard names for axes components
1 parent 8ec3b50 commit a0317b5

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

src/components/fields/AxisCreator.js renamed to src/components/fields/AxesCreator.js

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
axisIdToAxisName,
1313
} from 'lib';
1414

15-
class UnconnectedNewAxisCreator extends Component {
15+
class UnconnectedAxisCreator extends Component {
1616
canAddAxis() {
1717
const currentAxisId = this.props.fullContainer[this.props.attr];
1818
const currentTraceIndex = this.props.fullContainer.index;
@@ -104,7 +104,7 @@ class UnconnectedNewAxisCreator extends Component {
104104
}
105105
}
106106

107-
UnconnectedNewAxisCreator.propTypes = {
107+
UnconnectedAxisCreator.propTypes = {
108108
attr: PropTypes.string,
109109
label: PropTypes.string,
110110
options: PropTypes.array,
@@ -114,16 +114,16 @@ UnconnectedNewAxisCreator.propTypes = {
114114
updateContainer: PropTypes.func,
115115
};
116116

117-
UnconnectedNewAxisCreator.contextTypes = {
117+
UnconnectedAxisCreator.contextTypes = {
118118
fullLayout: PropTypes.object,
119119
data: PropTypes.array,
120120
fullData: PropTypes.array,
121121
onUpdate: PropTypes.func,
122122
};
123123

124-
const ConnectedNewAxisCreator = connectToContainer(UnconnectedNewAxisCreator);
124+
const AxisCreator = connectToContainer(UnconnectedAxisCreator);
125125

126-
class AxisCreator extends Component {
126+
class UnconnectedAxesCreator extends Component {
127127
render() {
128128
const isFirstTraceOfType =
129129
this.context.data.filter(d => d.type === this.props.container.type)
@@ -148,7 +148,7 @@ class AxisCreator extends Component {
148148
if (axisType === 'cartesian') {
149149
['xaxis', 'yaxis'].forEach((type, index) => {
150150
controls.push(
151-
<ConnectedNewAxisCreator
151+
<AxisCreator
152152
key={index}
153153
attr={type}
154154
label={type.charAt(0).toUpperCase() + ' Axis'}
@@ -169,19 +169,19 @@ class AxisCreator extends Component {
169169
}
170170
}
171171

172-
AxisCreator.propTypes = {
172+
UnconnectedAxesCreator.propTypes = {
173173
container: PropTypes.object,
174174
fullContainer: PropTypes.object,
175175
};
176176

177-
AxisCreator.contextTypes = {
177+
UnconnectedAxesCreator.contextTypes = {
178178
data: PropTypes.array,
179179
fullData: PropTypes.array,
180180
fullLayout: PropTypes.object,
181181
localize: PropTypes.func,
182182
};
183183

184-
export default connectToContainer(AxisCreator, {
184+
export default connectToContainer(UnconnectedAxesCreator, {
185185
modifyPlotProps: (props, context, plotProps) => {
186186
const {data} = context;
187187
const {fullContainer} = plotProps;

src/components/fields/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import Text from './Text';
1616
import SymbolSelector from './SymbolSelector';
1717
import TraceSelector from './TraceSelector';
1818
import ErrorBars from './ErrorBars';
19-
import AxisCreator from './AxisCreator';
19+
import AxesCreator from './AxesCreator';
2020
import UpdateMenuButtons from './UpdateMenuButtons';
2121
import {FilterOperation, FilterValue} from './FilterOperation';
2222
import MarkerSize from './MarkerSize';
@@ -83,7 +83,7 @@ export {
8383
TextEditor,
8484
TraceOrientation,
8585
TraceSelector,
86-
AxisCreator,
86+
AxesCreator,
8787
AxisOverlayDropdown,
8888
AxisSide,
8989
UpdateMenuButtons,

src/components/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ import {
3535
Text,
3636
Radio,
3737
RangesliderVisible,
38-
AxisCreator,
38+
AxesCreator,
3939
SymbolSelector,
4040
TextEditor,
4141
TraceOrientation,
@@ -130,7 +130,7 @@ export {
130130
PlotlySection,
131131
Section,
132132
SingleSidebarItem,
133-
AxisCreator,
133+
AxesCreator,
134134
SymbolSelector,
135135
TextEditor,
136136
TraceAccordion,

src/default_panels/GraphCreatePanel.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
Radio,
88
PlotlySection,
99
LayoutSection,
10-
AxisCreator,
10+
AxesCreator,
1111
TraceAccordion,
1212
TraceSelector,
1313
TextEditor,
@@ -107,7 +107,7 @@ const GraphCreatePanel = (props, {localize: _}) => {
107107
</TraceTypeSection>
108108

109109
<PlotlySection name={_('Axes to Use')}>
110-
<AxisCreator attr="fake_attr" />
110+
<AxesCreator attr="fake_attr" />
111111
</PlotlySection>
112112

113113
<PlotlySection name={_('Error Bars X')}>

0 commit comments

Comments
 (0)