check that share key is enabled #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriddyp
reviewed
Apr 6, 2017
plotly/plotly/plotly.py
Outdated
| @@ -1308,7 +1308,14 @@ def add_share_key_to_url(plot_url): | |||
| body = {'share_key_enabled': True, 'world_readable': False} | |||
| response = v2.files.update(fid, body) | |||
|
|
|||
| return plot_url + '?share_key=' + response.json()['share_key'] | |||
| if not v2.files.retrieve(fid).json()['share_key_enabled']: | |||
There was a problem hiding this comment.
I'd add a comment here about why we're trying multiple times
chriddyp
reviewed
Apr 6, 2017
plotly/plotly/plotly.py
Outdated
| return plot_url + '?share_key=' + response.json()['share_key'] | ||
| if not v2.files.retrieve(fid).json()['share_key_enabled']: | ||
| attempt += 1 | ||
| if attempt == 10: |
There was a problem hiding this comment.
I'd be OK with bumping this up to 50 even
chriddyp
reviewed
Apr 6, 2017
plotly/plotly/plotly.py
Outdated
| if not v2.files.retrieve(fid).json()['share_key_enabled']: | ||
| attempt += 1 | ||
| if attempt == 10: | ||
| raise Exception |
There was a problem hiding this comment.
We're trying to wrap everything in plotly exceptions so that users can catch them. So just: raise exceptions.PlotlyException (or something)
|
💃 once you consider my comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.