fix: Avoid using iter_rows in _check_dataframe_all_leaves to enable cuDF input #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
force-pushed
the
avoid-iter-row
branch
from
cef56e2 to
a3bcae2
Compare
MarcoGorelli
force-pushed
the
avoid-iter-row
branch
from
a3bcae2 to
52d562a
Compare
gvwilson
added
P1
|
I've tested this and it works well for me now. Thanks @MarcoGorelli |
|
@MarcoGorelli Big thanks for this fix. I'd like to get this in to the release — do you have a minute to merge master into this branch? Or are you OK with me doing it? From a quick glance at the "conflict" I don't see any issue, it's just highlighting the changes you made in |
|
This change seems to be covered by this test — thanks @LiamConnors for tracking it down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4876
This rewrites the same operation to avoid iterating over rows