From e12421630d2680c5e8b9319720794fdf1c1f086e Mon Sep 17 00:00:00 2001 From: Ben West Date: Tue, 1 Aug 2023 21:13:07 +0200 Subject: [PATCH 1/3] px.line: don't use webgl for spline shape If line_shape="spline" is set and render_mode="auto", don't default to webgl (go.Scattergl) as it doesn't support line_shape="spline". --- packages/python/plotly/plotly/express/_core.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index 24135fa293f..0ac14dcd6bb 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -812,6 +812,7 @@ def make_trace_spec(args, constructor, attrs, trace_patch): or ( args["render_mode"] == "auto" and len(args["data_frame"]) > 1000 + and args["line_shape"] != "spline" and args["animation_frame"] is None ) ): From 04bd8b90254d0866ede5eabe154660d3a47d7eaa Mon Sep 17 00:00:00 2001 From: Alex Johnson Date: Wed, 8 Nov 2023 14:34:29 -0500 Subject: [PATCH 2/3] Update packages/python/plotly/plotly/express/_core.py --- packages/python/plotly/plotly/express/_core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py index 88dfac92ce4..5de16add69a 100644 --- a/packages/python/plotly/plotly/express/_core.py +++ b/packages/python/plotly/plotly/express/_core.py @@ -812,7 +812,7 @@ def make_trace_spec(args, constructor, attrs, trace_patch): or ( args["render_mode"] == "auto" and len(args["data_frame"]) > 1000 - and args["line_shape"] != "spline" + and args.get("line_shape") != "spline" and args["animation_frame"] is None ) ): From 2c5fdba026b9a9c099adcab928560f96d02d00e5 Mon Sep 17 00:00:00 2001 From: Ben West <73724178+bwest2397@users.noreply.github.com> Date: Fri, 10 Nov 2023 17:10:55 -0500 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f283c6e141..4673caf3790 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ This project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - Fix issue with creating dendrogram in subplots [[#4411](https://github.com/plotly/plotly.py/pull/4411)], +- Fix issue with px.line not accepting "spline" line shape [[#2812](https://github.com/plotly/plotly.py/issues/2812)], ## [5.18.0] - 2023-10-25