-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docs for next release + Update Plotlyjs version #4104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yay, the tests pass now that we have the JS bump in here :) Feel free to keep stacking on to this, including with the 2.20 JS bump once it comes and we can merge this whole thing in at once. |
Still need to add something for automargin in 2.20.0, but if you could start taking a look at what's here already, that would be great @archmoj. Thanks! |
@archmoj this one is ready for review. With examples based on 2.19.0 and 2.20.0 Plotly.js release |
All looking good to me. |
Last commit to fix issue with building the aggregations page when using that original link. Replaced it with a link to the same dataset in the datasets repo |
@@ -144,7 +144,7 @@ import plotly.io as pio | |||
|
|||
import pandas as pd | |||
|
|||
df = pd.read_csv("https://plotly.com/~public.health/17.csv") | |||
df = pd.read_csv("https://raw.githubusercontent.com/plotly/datasets/master/US-shooting-incidents.csv") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you please explain why this dataset is changed?
On another - IMHO it would be better to depend on a permanent link as these kind of files may change location and content in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pandas is sometimes unable to load the dataset from "https://plotly.com/~public.health/17.csv".
It sometimes throws an error and the tests were failing because of it.
We have a repo specifically for datasets that is where the updated link is. But it's the same dataset.
So it is now at https://plotly.github.io/datasets
. We actually have a check in the PR that new datasets should be loaded from there.
"New/modified remote datasets are loaded from https://plotly.github.io/datasets and added to https://github.com/plotly/datasets"
And this is where we load most external datasets from. For example, the pages on https://plotly.com/python/tick-formatting/
@LiamConnors would you mind checking the boxes in the PR description? |
💃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃🏼
This PR:
Documentation PR
doc/README.md
filedoc-prod
branch OR it targets themaster
branchpx
example if at all possibleplotly.graph_objects as go
/plotly.express as px
/plotly.io as pio
df
fig = <something>
call is high up in each new/modified example (eitherpx.<something>
ormake_subplots
orgo.Figure
)fig.add_*
andfig.update_*
rather thango.Figure(data=..., layout=...)
in every new/modified examplefig.add_shape
andfig.update_xaxes
are used instead of bigfig.update_layout
calls in every new/modified examplefig.show()
is at the end of each new/modified exampleplotly.plot()
andplotly.iplot()
are not used in any new/modified exampleCode PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
-->