From 945f8cce2c92e11511073dc37f5a3e1d022bc3a1 Mon Sep 17 00:00:00 2001 From: Karthikeyan Singaravelan Date: Wed, 26 Aug 2020 11:32:12 +0000 Subject: [PATCH 1/2] Fix warning regarding ABC import from collections --- packages/python/plotly/plotly/figure_factory/utils.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/python/plotly/plotly/figure_factory/utils.py b/packages/python/plotly/plotly/figure_factory/utils.py index cdd5657cddc..23e240b68e6 100644 --- a/packages/python/plotly/plotly/figure_factory/utils.py +++ b/packages/python/plotly/plotly/figure_factory/utils.py @@ -1,6 +1,5 @@ from __future__ import absolute_import -import collections import decimal import six @@ -24,9 +23,13 @@ validate_scale_values, ) +try: + from collections.abc import Sequence +except ImportError: + from collections import Sequence def is_sequence(obj): - return isinstance(obj, collections.Sequence) and not isinstance(obj, str) + return isinstance(obj, Sequence) and not isinstance(obj, str) def validate_index(index_vals): From 30d54a1ba5c3f71ab3ed5094bc88b83f1af2e734 Mon Sep 17 00:00:00 2001 From: Karthikeyan Singaravelan Date: Wed, 26 Aug 2020 11:49:20 +0000 Subject: [PATCH 2/2] Fix lint error. --- packages/python/plotly/plotly/figure_factory/utils.py | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/python/plotly/plotly/figure_factory/utils.py b/packages/python/plotly/plotly/figure_factory/utils.py index 23e240b68e6..d513f954a2e 100644 --- a/packages/python/plotly/plotly/figure_factory/utils.py +++ b/packages/python/plotly/plotly/figure_factory/utils.py @@ -28,6 +28,7 @@ except ImportError: from collections import Sequence + def is_sequence(obj): return isinstance(obj, Sequence) and not isinstance(obj, str)