Skip to content

removed go.layout. in docs #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

removed go.layout. in docs #2171

merged 1 commit into from
Feb 11, 2020

Conversation

Mahdis-z
Copy link
Contributor

@Mahdis-z Mahdis-z commented Feb 7, 2020

No description provided.

@Mahdis-z Mahdis-z requested a review from emmanuelle February 7, 2020 17:40
@Mahdis-z Mahdis-z mentioned this pull request Feb 7, 2020
Closed
@jdamiba
Copy link

jdamiba commented Feb 11, 2020 •
edited
Loading

The purpose of this PR is to replace references to the following functions in the Python docs with Python dicts in order to make the code easier to read and more in line with current best practice.

  • go.layout.Updatemenu()
  • go.layout.Annotation()
  • go.layout.Shape()
  • go.layout.Image()
  • go.layout.Geo()
  • go.layout.XAxis()
  • go.layout.YAxis()
  • go.layout.Mapbox()
  • go.layout.Margin()
  • go.layout.Template()

Testing Plan:

  • 0 results for a text search for go.layout.*
  • every modified example renders same as in production using jupyterlab + jupytext

Great work @Mahdis-z! 💃

@Mahdis-z Mahdis-z merged commit 0bfbe0e into doc-prod Feb 11, 2020
@Mahdis-z Mahdis-z deleted the remove_go.layout_ branch February 11, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmanuelle emmanuelle Awaiting requested review from emmanuelle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mahdis-z @jdamiba