Skip to content

Add additional templates to control grid lines #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2019

Conversation

joelostblom
Copy link
Contributor

Together with the xgridoff template these allow full control over which gridlines are visible.

@emmanuelle
Copy link
Contributor

Adding ygridoff is a good idea I think, for symmetry with xgridoff. On the other hand I'm not sure we need the gridon one since most default templates already display grid lines?

@nicolaskruchten
Copy link
Contributor

most default templates already display grid lines

I think the idea here is that @joelostblom's new template doesn't, so I like this idea personally.

@joelostblom
Copy link
Contributor Author

True, I believe it's only the template I proposed that doesn't have grid lines by default. I think it would be nice with gridon since the three together then covers all possible scenarios (adding or removing one or two grid lines) which makes it feel like a complete modular set, but I can remove it if you think there are too many templates.

@emmanuelle
Copy link
Contributor

Sounds good, I'm convinced now!

@emmanuelle
Copy link
Contributor

@joelostblom if you can find the time, could you please document these templates (at least the new one simple_white) in https://plot.ly/python/templates/? (the source is https://github.com/plotly/plotly.py-docs/blob/master/python/templates.md). You could just add the new template to the figure showing how a chart looks like with the different templates.

@joelostblom
Copy link
Contributor Author

@emmanuelle
Copy link
Contributor

great, merging

@emmanuelle emmanuelle merged commit 9da7cec into plotly:master Nov 5, 2019
@joelostblom joelostblom deleted the grid-templates branch November 5, 2019 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants