Skip to content

Retry requests to Plotly in our Python API #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kully opened this issue Feb 28, 2018 · 5 comments
Closed

Retry requests to Plotly in our Python API #949

Kully opened this issue Feb 28, 2018 · 5 comments
Assignees

Comments

@Kully
Copy link
Contributor

Kully commented Feb 28, 2018

Original Issue: https://github.com/plotly/streambed/issues/10634
I'm going to deal with this starting next Tuesday. Can do some preliminary look/testing/discussion today.

cc: @scjody @jackparmer

@Kully Kully self-assigned this Feb 28, 2018
@cldougl
Copy link
Member

cldougl commented Mar 7, 2018

@Kully this should help the intermittent test failures as well

@Kully
Copy link
Contributor Author

Kully commented Mar 7, 2018

Good resource I just found for the issue: https://www.peterbe.com/plog/best-practice-with-retries-with-requests

@scjody
Copy link

scjody commented Mar 7, 2018

The retrying library is a more general solution. The backend already uses it for some Google Cloud Storage requests as well as imageserver requests. The imageserver request PR is here: https://github.com/plotly/streambed/pull/10614/files

@jonmmease
Copy link
Contributor

This has been implemented in #942 and will be released as part of 3.0.0

@jonmmease
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants