Skip to content

Downloading malformed plot-schema.json can cause import plotly to break #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chriddyp opened this issue Nov 21, 2016 · 3 comments
Closed

Comments

@chriddyp
Copy link
Member

See #612 for the original issue that prompted this discussion.

To make sure that this never happens again, we should either:

  • Extend the try / except around the construction of graph_objs off of the downloaded plot-schema.json and use the cached version if it does not work
  • Remove the auto-downloading plot-schema.json on import and perform more frequent (weekly) releases of the python library in sync with the plotly.js version updates.
@etpinard
Copy link
Contributor

etpinard commented Nov 21, 2016

The more radical solution is implemented in #614

@rcscott
Copy link

rcscott commented Nov 22, 2016

I feel strongly that the auto-downloading should be removed. If someone wants the newest features then they can upgrade their plotly version. It's a strange design decision that the library can change automatically even if I have a specific version in my requirements.txt.

@theengineear
Copy link
Contributor

Removed in 1.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants