Skip to content

Discrepancy between install_requires and requirements.txt #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maresb opened this issue Jul 13, 2021 · 1 comment · Fixed by #3341
Closed

Discrepancy between install_requires and requirements.txt #3301

maresb opened this issue Jul 13, 2021 · 1 comment · Fixed by #3341

Comments

@maresb
Copy link
Contributor

maresb commented Jul 13, 2021

Question: Should we be pinning six at 1.15.0? Now that six is on 1.16.0 this can lead to downgrades.

From setup.py:

install_requires=["tenacity>=6.2.0", "six"],

There seems to be no pinning from setuptools.

However, from requirements.txt:

six==1.15.0

(and also tenacity>=6.2.0)

I notice that six is slated for removal (#3167), so I hope the pinning is unnecessary, but I'm not sure.

Any guidance on this question would be very helpful over at conda-forge regarding conda-forge/plotly-feedstock#94

@nicolaskruchten
Copy link
Contributor

I can't think of a reason to pin it, I think it's just historical. We're planning on removing six sometime anyway as we don't support Python 2.7 any more :) See also #3167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants