Skip to content

Remove nosetests from our CI build (Was:Bring back test_jupyter) #2042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Jan 7, 2020 · 2 comments
Closed

Remove nosetests from our CI build (Was:Bring back test_jupyter) #2042

nicolaskruchten opened this issue Jan 7, 2020 · 2 comments
Milestone
v4.6.0

Comments

@nicolaskruchten
Copy link
Contributor

We should undo this PR sometime soon: #2041
@nicolaskruchten
Copy link
Contributor Author

from Slack

Jon Mease 15:03
I'm not sure what might have changed, but I think we can 🔪 these tests. The modern version of this functionality is pretty well tested in packages/python/plotly/plotly/tests/test_io/test_renderers.py.
As I recall, these were also the only tests we have that weren't working with pytest, so we may be able to switch all of the test invocations from nosetests to pytest as well.

@emmanuelle emmanuelle changed the title Bring back test_jupyter Remove nosetests from our CI build ~~Bring back test_jupyter~~ Feb 10, 2020
@emmanuelle emmanuelle changed the title Remove nosetests from our CI build ~~Bring back test_jupyter~~ Remove nosetests from our CI build (Was:Bring back test_jupyter) Feb 10, 2020
@emmanuelle emmanuelle added this to the v4.6.0 milestone Feb 10, 2020
@emmanuelle
Copy link
Contributor

closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.6.0
Development

No branches or pull requests
2 participants
@nicolaskruchten @emmanuelle