Skip to content

plotlyServerURL config option overridden by plotly_domain from ~/.plotly/.config #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelbabyn opened this issue Jun 13, 2019 · 0 comments · Fixed by #1615
Closed
Labels
bug something broken

Comments

@michaelbabyn
Copy link
Contributor

Setting plotlyServerURL in the config dict passed to iplot will always create a plot where the "Edit in Chart Studio" button sends the plot to the base url defined by plotly_domain.

This code won't change the plotly url used by the "Edit in Chart Studio" button

import plotly.offline as py
import plotly.graph_objs as go
py.init_notebook_mode()

py.iplot([go.Scatter(y=[2,3,4])], config=dict(showSendToCloud = True, plotlyServerURL='https://myserver.com'))

and this code will

import plotly.offline as py
import plotly.graph_objs as go
import plotly.tools as tls
py.init_notebook_mode()

tls.set_config_file(plotly_domain='https://www.myserver.com')
py.iplot([go.Scatter(y=[2,3,4])], config=dict(showSendToCloud = True))

I think it would be good to add a check to see if plotlyServerURL is already present in the config dict before setting it to plotly_domain (relevant code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants