Skip to content

Commit d4a733c

Browse files
work out line shape for ecdfmode
1 parent 9fd2f6b commit d4a733c

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

Diff for: packages/python/plotly/plotly/express/_chart_types.py

-1
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,6 @@ def ecdf(
519519
marginal=None,
520520
opacity=None,
521521
orientation=None,
522-
line_shape="hv",
523522
ecdfnorm="probability",
524523
ecdfmode="standard",
525524
render_mode="auto",

Diff for: packages/python/plotly/plotly/express/_core.py

+4
Original file line numberDiff line numberDiff line change
@@ -1825,6 +1825,10 @@ def infer_config(args, constructor, trace_patch, layout_patch):
18251825

18261826
if "line_shape" in args:
18271827
trace_patch["line"] = dict(shape=args["line_shape"])
1828+
elif "ecdfmode" in args:
1829+
trace_patch["line"] = dict(
1830+
shape="vh" if args["ecdfmode"] == "reversed" else "hv"
1831+
)
18281832

18291833
if "geojson" in args:
18301834
trace_patch["featureidkey"] = args["featureidkey"]

0 commit comments

Comments
 (0)