Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit cae9d77

Browse files
committedFeb 12, 2025·
remove unnecessary py parameter and add numpy_installed parameter
1 parent 719292e commit cae9d77

File tree

4 files changed

+25
-132
lines changed

4 files changed

+25
-132
lines changed
 

‎.circleci/config.yml

Lines changed: 25 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ orbs:
55

66
commands:
77
test_core:
8-
parameters:
9-
py:
10-
default: "310"
11-
type: string
128
steps:
139
- checkout
1410
- browser-tools/install-chrome
@@ -29,9 +25,9 @@ commands:
2925

3026
test_optional:
3127
parameters:
32-
py:
33-
default: "310"
34-
type: string
28+
numpy_installed:
29+
default: true
30+
type: boolean
3531
steps:
3632
- checkout
3733
- browser-tools/install-chrome
@@ -47,6 +43,16 @@ commands:
4743
cd js
4844
npm ci
4945
npm run build
46+
- when:
47+
condition:
48+
equal: ["<< parameters.numpy_installed >>", false]
49+
steps:
50+
- run:
51+
name: Uninstall numpy
52+
command: |
53+
source .venv/bin/activate
54+
uv pip uninstall numpy
55+
5056
- run:
5157
name: Test core
5258
command: |
@@ -106,105 +112,70 @@ jobs:
106112
docker:
107113
- image: cimg/python:3.8-browsers
108114
steps:
109-
- test_core:
110-
py: "38"
115+
- test_core
111116

112117
python_39_core:
113118
docker:
114119
- image: cimg/python:3.9-browsers
115120
steps:
116-
- test_core:
117-
py: "39"
121+
- test_core
118122

119123
python_310_core:
120124
docker:
121125
- image: cimg/python:3.10-browsers
122126
steps:
123-
- test_core:
124-
py: "310"
127+
- test_core
125128

126129
python_311_core:
127130
docker:
128131
- image: cimg/python:3.11-browsers
129132
steps:
130-
- test_core:
131-
py: "311"
133+
- test_core
132134

133135
python_312_core:
134136
docker:
135137
- image: cimg/python:3.12-browsers
136138
steps:
137-
- test_core:
138-
py: "312"
139+
- test_core
139140

140141
# Optional
141-
142142
python_38_optional:
143143
docker:
144144
- image: cimg/python:3.8-browsers
145145
steps:
146-
- test_optional:
147-
py: "38"
146+
- test_optional
148147

149148
python_39_optional:
150149
docker:
151150
- image: cimg/python:3.9-browsers
152151
steps:
153-
- test_optional:
154-
py: "39"
152+
- test_optional
155153

156154
python_310_optional:
157155
docker:
158156
- image: cimg/python:3.10-browsers
159157
steps:
160-
- test_optional:
161-
py: "310"
158+
- test_optional
162159

163160
python_311_optional:
164161
docker:
165162
- image: cimg/python:3.11-browsers
166163
steps:
167-
- test_optional:
168-
py: "311"
164+
- test_optional
169165

170166
python_312_optional:
171167
docker:
172168
- image: cimg/python:3.12-browsers
173169
steps:
174-
- test_optional:
175-
py: "312"
176-
177-
# Pandas
178-
179-
python_39_pandas_2_optional:
180-
docker:
181-
- image: cimg/python:3.9-browsers
182-
steps:
183-
- test_optional:
184-
py: "39_pandas_2"
170+
- test_optional
185171

186172
# No numpy
187173
python_312_no_numpy:
188174
docker:
189175
- image: cimg/python:3.12-browsers
190176
steps:
191-
- run:
192-
name: Check that numpy is not installed
193-
command: |
194-
if pip list | grep numpy > /dev/null 2>&1
195-
then exit 1
196-
else exit 0
197-
fi
198177
- test_optional:
199-
py: "312_no_numpy"
200-
201-
python_312_np2:
202-
docker:
203-
- image: cimg/python:3.12-browsers
204-
steps:
205-
- test_optional:
206-
py: "312_np2"
207-
178+
numpy_installed: false
208179

209180
# Percy
210181
python_39_percy:
@@ -229,8 +200,7 @@ jobs:
229200
python -m venv venv
230201
. venv/bin/activate
231202
pip install -e .
232-
pip install plotly-geo
233-
pip install -r test_requirements/requirements_39_pandas_2_optional.txt
203+
pip install -r test_requirements/requirements_optional.txt
234204
235205
- run:
236206
name: Build html figures (Pandas 2)
@@ -477,8 +447,6 @@ workflows:
477447
- python_310_optional
478448
- python_311_optional
479449
- python_312_optional
480-
- python_39_pandas_2_optional
481450
- python_39_percy
482451
- python_312_no_numpy
483-
- python_312_np2
484452
- build-doc

‎test_requirements/requirements_312_no_numpy_optional.txt

Lines changed: 0 additions & 24 deletions
This file was deleted.

‎test_requirements/requirements_312_np2_optional.txt

Lines changed: 0 additions & 25 deletions
This file was deleted.

‎test_requirements/requirements_39_pandas_2_optional.txt

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.