Make offline tests less annoying :)

theengineear · theengineear · commit 9a7a8f1e21aa · 2017-01-31T13:24:01.000-05:00
1. no side effect files from running tests
2. don’t auto-open plot in browser, it auto-focuses and is incredibly
distracting when multi-tasking.
diff --git a/plotly/tests/test_core/test_offline/test_offline.py b/plotly/tests/test_core/test_offline/test_offline.py
@@ -4,6 +4,7 @@
 """
 from __future__ import absolute_import
 
+import os
 from unittest import TestCase
 
 from requests.compat import json as _json
@@ -24,7 +25,16 @@
 PLOTLYJS = plotly.offline.offline.get_plotlyjs()
 
 
-class PlotlyOfflineTestCase(TestCase):
+class PlotlyOfflineBaseTestCase(TestCase):
+    def tearDown(self):
+        # Some offline tests produce an html file. Make sure we clean up :)
+        try:
+            os.remove('temp-plot.html')
+        except OSError:
+            pass
+
+
+class PlotlyOfflineTestCase(PlotlyOfflineBaseTestCase):
     def setUp(self):
         pass
 
@@ -42,7 +52,7 @@ def test_default_plot_generates_expected_html(self):
             fig['layout'],
             cls=plotly.utils.PlotlyJSONEncoder)
 
-        html = self._read_html(plotly.offline.plot(fig))
+        html = self._read_html(plotly.offline.plot(fig, auto_open=False))
 
         # I don't really want to test the entire script output, so
         # instead just make sure a few of the parts are in here?
@@ -54,11 +64,12 @@ def test_default_plot_generates_expected_html(self):
         self.assertTrue(html.startswith('<html>') and html.endswith('</html>'))
 
     def test_including_plotlyjs(self):
-        html = self._read_html(plotly.offline.plot(fig, include_plotlyjs=False))
+        html = self._read_html(plotly.offline.plot(fig, include_plotlyjs=False,
+                                                   auto_open=False))
         self.assertTrue(PLOTLYJS not in html)
 
     def test_div_output(self):
-        html = plotly.offline.plot(fig, output_type='div')
+        html = plotly.offline.plot(fig, output_type='div', auto_open=False)
 
         self.assertTrue('<html>' not in html and '</html>' not in html)
         self.assertTrue(html.startswith('<div>') and html.endswith('</div>'))
@@ -69,7 +80,7 @@ def test_autoresizing(self):
             'Plotly.Plots.resize('
         ]
         # If width or height wasn't specified, then we add a window resizer
-        html = self._read_html(plotly.offline.plot(fig))
+        html = self._read_html(plotly.offline.plot(fig, auto_open=False))
         for resize_code_string in resize_code_strings:
             self.assertTrue(resize_code_string in html)
 
@@ -79,12 +90,12 @@ def test_autoresizing(self):
             'layout': {
                 'width': 500, 'height': 500
             }
-        })
+        }, auto_open=False)
         for resize_code_string in resize_code_strings:
             self.assertTrue(resize_code_string not in html)
 
 
-class PlotlyOfflineOtherDomainTestCase(PlotlyTestCase):
+class PlotlyOfflineOtherDomainTestCase(PlotlyOfflineBaseTestCase):
     def setUp(self):
         super(PlotlyOfflineOtherDomainTestCase, self).setUp()
         plotly.tools.set_config_file(plotly_domain='https://stage.plot.ly',
