Skip to content

Commit 95cded8

Browse files
committed
update insets loop:
- update start cell convention - i,j -> r.c - fill in insets_ref !
1 parent f0eea15 commit 95cded8

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

plotly/tools.py

+15-14
Original file line numberDiff line numberDiff line change
@@ -951,50 +951,51 @@ def _add_domain_is_3d(layout, s_label, x_domain, y_domain):
951951
if insets:
952952
for i_inset, inset in enumerate(insets):
953953

954-
i = inset['cell'][0]
955-
j = inset['cell'][1]
954+
r = inset['cell'][0] - 1
955+
c = inset['cell'][1] - 1
956956

957957
# Get inset x domain using grid
958-
x_s = grid[i][j][0] + inset['l'] * width
958+
x_s = grid[r][c][0] + inset['l'] * width
959959
if inset['w'] == 'to_end':
960-
x_e = grid[i][j][0] + width
960+
x_e = grid[r][c][0] + width
961961
else:
962962
x_e = x_s + inset['w'] * width
963963
x_domain = [x_s, x_e]
964964

965965
# Get inset y domain using grid
966-
y_s = grid[i][j][1] + inset['b'] * height
966+
y_s = grid[r][c][1] + inset['b'] * height
967967
if inset['h'] == 'to_end':
968-
y_e = grid[i][j][1] + height
968+
y_e = grid[r][c][1] + height
969969
else:
970970
y_e = y_s + inset['h'] * height
971971
y_domain = [y_s, y_e]
972972

973973
if inset['is_3d']:
974+
974975
# Add scene to layout
975-
_add_domain_is_3d(fig, s_cnt, x_domain, y_domain)
976-
if print_grid:
977-
insets_str[i_inset] = '[scene{}]'.format(s_cnt)
976+
s_label = 'scene{0}'.format(s_cnt)
977+
_add_domain_is_3d(layout, s_label, x_domain, y_domain)
978+
insets_ref[i_inset] = (s_label, )
978979
s_cnt += 1
980+
979981
else:
980982

981983
# Get axis label and anchor
982984
x_label = _get_label('x', False, False, x_cnt, False)
983985
y_label = _get_label('y', False, False, y_cnt, False)
984-
x_anchor, y_anchor = _get_anchors(row, col,
986+
x_anchor, y_anchor = _get_anchors(r, c,
985987
x_cnt, y_cnt,
986988
False, False)
987989

988990
# Add a xaxis to layout (N.B insets always have anchors)
989-
_add_domain(fig, 'x', x_label, x_domain, x_anchor, False)
991+
_add_domain(layout, 'x', x_label, x_domain, x_anchor, False)
990992
x_cnt += 1
991993

992994
# Add a yayis to layout (N.B insets always have anchors)
993-
_add_domain(fig, 'y', y_label, y_domain, y_anchor, False)
995+
_add_domain(layout, 'y', y_label, y_domain, y_anchor, False)
994996
y_cnt += 1
995997

996-
if print_grid:
997-
insets_str[i_inset] = '[{},{}]'.format(x_label, y_label)
998+
insets_ref[i_inset] = (x_label, y_label) # fill in ref
998999

9991000
if print_grid:
10001001
print("This is the format of your plot grid!")

0 commit comments

Comments
 (0)