Skip to content

Commit 69339e2

Browse files
committed
Don't be picky about the status code on expected PlotlyRequestErrors
This was another source of flaky test failures
1 parent 779e149 commit 69339e2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

plotly/tests/test_core/test_file/test_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,6 @@ def test_duplicate_folders(self):
5050
try:
5151
py.file_ops.mkdirs(first_folder)
5252
except PlotlyRequestError as e:
53-
self.assertTrue(400 <= e.status_code < 500)
53+
pass
5454
else:
5555
self.fail('Expected this to fail!')

plotly/tests/test_core/test_grid/test_grid.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,4 +178,6 @@ def test_duplicate_filenames(self):
178178
try:
179179
py.grid_ops.upload(g, unique_filename, auto_open=False)
180180
except PlotlyRequestError as e:
181-
assert(e.status_code == 409)
181+
pass
182+
else:
183+
self.fail('Expected this to fail!')

0 commit comments

Comments
 (0)