Skip to content

Commit 2e7c0ff

Browse files
authored
Merge pull request #1671 from plotly/move_traces_message_order
Send the moveTraces message after the figure's data has been updated.
2 parents c576adf + bc48a18 commit 2e7c0ff

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

Diff for: packages/python/plotly/plotly/basedatatypes.py

+6-2
Original file line numberDiff line numberDiff line change
@@ -642,8 +642,9 @@ def data(self, new_data):
642642
# ### Check whether a move is needed ###
643643
if not all([i1 == i2 for i1, i2 in zip(new_inds, current_inds)]):
644644

645-
# #### Update widget, if any ####
646-
self._send_moveTraces_msg(current_inds, new_inds)
645+
# #### Save off index lists for moveTraces message ####
646+
msg_current_inds = current_inds
647+
msg_new_inds = new_inds
647648

648649
# #### Reorder trace elements ####
649650
# We do so in-place so we don't trigger traitlet property
@@ -664,6 +665,9 @@ def data(self, new_data):
664665
for ni, trace_data in zip(new_inds, moving_traces_data):
665666
self._data.insert(ni, trace_data)
666667

668+
# #### Update widget, if any ####
669+
self._send_moveTraces_msg(msg_current_inds, msg_new_inds)
670+
667671
# ### Update data defaults ###
668672
# There is to front-end syncronization to worry about so this
669673
# operations doesn't need to be in-place

0 commit comments

Comments
 (0)