we only need to check barmode in layout_patch, not args

emilykl · emilykl · commit 298f5ce9e59d · 2024-11-15T15:06:14.000-05:00
diff --git a/packages/python/plotly/plotly/express/_core.py b/packages/python/plotly/plotly/express/_core.py
@@ -2558,7 +2558,7 @@ def make_figure(args, constructor, trace_patch=None, layout_patch=None):
                 )
 
             # Set 'offsetgroup' only in group barmode (or if no barmode is set)
-            barmode = args.get("barmode") or layout_patch.get("barmode")
+            barmode = layout_patch.get("barmode")
             if trace_spec.constructor in [go.Bar, go.Box, go.Violin, go.Histogram] and (
                 barmode == "group" or barmode is None
             ):

Original file line number	Diff line number	Diff line change
`@@ -2558,7 +2558,7 @@ def make_figure(args, constructor, trace_patch=None, layout_patch=None):`
`2558`	`2558`	`)`
`2559`	`2559`
`2560`	`2560`	`# Set 'offsetgroup' only in group barmode (or if no barmode is set)`
`2561`		`- barmode = args.get("barmode") or layout_patch.get("barmode")`
	`2561`	`+ barmode = layout_patch.get("barmode")`
`2562`	`2562`	`if trace_spec.constructor in [go.Bar, go.Box, go.Violin, go.Histogram] and (`
`2563`	`2563`	`barmode == "group" or barmode is None`
`2564`	`2564`	`):`