Skip to content

Commit 0eeaaa5

Browse files
author
Jon M. Mease
committed
Review / cleanup of basedatatypes.py
1 parent aea6dfe commit 0eeaaa5

File tree

5 files changed

+2488
-1055
lines changed

5 files changed

+2488
-1055
lines changed

_plotly_utils/basevalidators.py

-5
Original file line numberDiff line numberDiff line change
@@ -1565,11 +1565,6 @@ def data_class(self):
15651565

15661566
def validate_coerce(self, v):
15671567

1568-
if isinstance(self.data_class, str):
1569-
raise ValueError(
1570-
"Invalid data_class of type 'string': {data_class}"
1571-
.format(data_class=self.data_class))
1572-
15731568
if v is None:
15741569
v = ()
15751570

codegen/datatypes.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def {literal_node.name_property}(self) -> {prop_type}:
171171
# property parent name
172172
# --------------------
173173
@property
174-
def _parent_path(self) -> str:
174+
def _parent_path_str(self) -> str:
175175
return '{node.parent_path_str}'
176176
177177
# Self properties description

js/src/Figure.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1628,7 +1628,7 @@ function performRestyleLike(parentArray, restyleData, restyleTraces) {
16281628
// Set property value
16291629
if (singleVal === null) {
16301630
_.unset(trace, rawKey);
1631-
} else {
1631+
} else if (singleVal !== undefined){
16321632
_.set(trace, rawKey, singleVal);
16331633
}
16341634
}

0 commit comments

Comments
 (0)