Skip to content

Add detailed explanations to Sunburst basic example #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

KangboLu
Copy link
Contributor

The sunburst basic example doesn't have explanation, so I wanna add it to the documentation for readers to understand faster.

Doc upgrade checklist:

  • random seed is set if using random data
  • file has been moved from unconverted/x/y.md to x/y.md
  • old boilerplate at top and bottom of file has been removed
  • Every example is independently runnable and is optimized for short line count
  • no more plot() or iplot()
  • graph_objs has been renamed to graph_objects
  • fig = <something> call is high up in each example
  • minimal creation of intermediate trace objects
  • liberal use of add_trace and update_layout
  • fig.show() at the end of each example
  • px example at the top if appropriate
  • minimize usage of hex codes for colors in favour of those in https://github.com/plotly/plotly.py-docs/issues/14

The sunburst basic example doesn't have explanation, so I wanna add it to the documentation for readers to understand faster.
@emmanuelle
Copy link
Contributor

Thank you for your changes. I corrected a few typos and moved the comment about the layout as a comment in the code so that the text focusses on the chart only. I pushed this commit to your branch but unfortunately this includes a merge which added other commits already merged. If you're happy with the changes I made, maybe the best thing would be to start a new PR with only the sunburst file, and then I'll merge. Sorry about that!

@KangboLu
Copy link
Contributor Author

KangboLu commented Oct 6, 2019

@emmanuelle Thanks for pointing out.
See the new PR here: #135.

@KangboLu KangboLu closed this Oct 6, 2019
@KangboLu KangboLu deleted the patch-1 branch October 6, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants