From 85b60d2a393f775150de034d8b3a240f7e3404d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Thu, 22 Sep 2016 15:50:39 -0400 Subject: [PATCH 1/2] updatemenus: add 'update' to list of available methods --- src/components/updatemenus/attributes.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/updatemenus/attributes.js b/src/components/updatemenus/attributes.js index 0a136827a13..715f35ddd30 100644 --- a/src/components/updatemenus/attributes.js +++ b/src/components/updatemenus/attributes.js @@ -17,7 +17,7 @@ var buttonsAttrs = { method: { valType: 'enumerated', - values: ['restyle', 'relayout', 'animate'], + values: ['restyle', 'relayout', 'animate', 'update'], dflt: 'restyle', role: 'info', description: [ From 8db01102d5934927c43fea1d175e506af5fc2942 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Thu, 22 Sep 2016 15:51:07 -0400 Subject: [PATCH 2/2] test: add check for updatemenu 'update' and 'animate' args --- test/jasmine/tests/updatemenus_test.js | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/test/jasmine/tests/updatemenus_test.js b/test/jasmine/tests/updatemenus_test.js index 4a47fea1b4f..36fe6366325 100644 --- a/test/jasmine/tests/updatemenus_test.js +++ b/test/jasmine/tests/updatemenus_test.js @@ -25,6 +25,12 @@ describe('update menus defaults', function() { buttons: [{ method: 'relayout', args: ['title', 'Hello World'] + }, { + method: 'update', + args: [ { 'marker.size': 20 }, { 'xaxis.range': [0, 10] }, [0, 1] ] + }, { + method: 'animate', + args: [ 'frame1', { transition: { duration: 500, ease: 'cubic-in-out' }}] }] }, { bgcolor: 'red' @@ -40,8 +46,13 @@ describe('update menus defaults', function() { expect(layoutOut.updatemenus[0].visible).toBe(true); expect(layoutOut.updatemenus[0].active).toEqual(0); + expect(layoutOut.updatemenus[0].buttons[0].args.length).toEqual(2); + expect(layoutOut.updatemenus[0].buttons[1].args.length).toEqual(3); + expect(layoutOut.updatemenus[0].buttons[2].args.length).toEqual(2); + expect(layoutOut.updatemenus[1].visible).toBe(false); expect(layoutOut.updatemenus[1].active).toBeUndefined(); + expect(layoutOut.updatemenus[2].visible).toBe(false); expect(layoutOut.updatemenus[2].active).toBeUndefined(); });