From e6edb3daa8cf822f60c60316ca4747c956bcc5dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89tienne=20T=C3=A9treault-Pinard?= Date: Mon, 22 Aug 2016 11:21:05 -0400 Subject: [PATCH] fix range selector position logic for overlaying axes --- src/components/rangeselector/defaults.js | 3 ++- test/jasmine/tests/range_selector_test.js | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/rangeselector/defaults.js b/src/components/rangeselector/defaults.js index 762d2a6ecbb..bb568c2479c 100644 --- a/src/components/rangeselector/defaults.js +++ b/src/components/rangeselector/defaults.js @@ -83,7 +83,8 @@ function getPosDflt(containerOut, layout, counterAxes) { var posY = 0; for(var i = 0; i < anchoredList.length; i++) { - posY = Math.max(layout[anchoredList[i]].domain[1], posY); + var domain = layout[anchoredList[i]].domain; + if(domain) posY = Math.max(domain[1], posY); } return [containerOut.domain[0], posY + constants.yPad]; diff --git a/test/jasmine/tests/range_selector_test.js b/test/jasmine/tests/range_selector_test.js index 8672b92414e..fd8a8072549 100644 --- a/test/jasmine/tests/range_selector_test.js +++ b/test/jasmine/tests/range_selector_test.js @@ -161,7 +161,7 @@ describe('range selector defaults:', function() { }, yaxis2: { anchor: 'x', - domain: [0.3, 0.55] + overlaying: 'y' }, yaxis3: { anchor: 'x',