From 23ee65b1aa29f7dbb64fe718a969863bb00af286 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Sat, 13 Jul 2024 18:20:46 -0400 Subject: [PATCH 1/3] test for Pr 5879 --- test/jasmine/tests/modebar_test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js index dc271a818a7..166ce77f27d 100644 --- a/test/jasmine/tests/modebar_test.js +++ b/test/jasmine/tests/modebar_test.js @@ -1630,7 +1630,7 @@ describe('ModeBar', function() { ]); }) .then(function() { - expect(countButtons()).toBe(initial + 3); + expect(countButtons()).toBe(initial + 4); return Plotly.relayout(gd, 'modebar.add', [ 'v1hovermode', @@ -1642,7 +1642,7 @@ describe('ModeBar', function() { ]); }) .then(function() { - expect(countButtons()).toBe(initial + 4, 'skip duplicates'); + expect(countButtons()).toBe(initial + 5, 'skip duplicates'); return Plotly.relayout(gd, 'modebar.add', [ 'drawline', From 385e6715e733c20da50f976b147235733d10b3d2 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Mon, 15 Jul 2024 08:57:35 -0400 Subject: [PATCH 2/3] Revert "test for Pr 5879" This reverts commit 23ee65b1aa29f7dbb64fe718a969863bb00af286. --- test/jasmine/tests/modebar_test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js index 166ce77f27d..dc271a818a7 100644 --- a/test/jasmine/tests/modebar_test.js +++ b/test/jasmine/tests/modebar_test.js @@ -1630,7 +1630,7 @@ describe('ModeBar', function() { ]); }) .then(function() { - expect(countButtons()).toBe(initial + 4); + expect(countButtons()).toBe(initial + 3); return Plotly.relayout(gd, 'modebar.add', [ 'v1hovermode', @@ -1642,7 +1642,7 @@ describe('ModeBar', function() { ]); }) .then(function() { - expect(countButtons()).toBe(initial + 5, 'skip duplicates'); + expect(countButtons()).toBe(initial + 4, 'skip duplicates'); return Plotly.relayout(gd, 'modebar.add', [ 'drawline', From cadbbf6b7e03c5165eaf69233f602c88f59684f7 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Wed, 17 Jul 2024 11:41:38 -0400 Subject: [PATCH 3/3] fix adding togglehover and add test --- src/components/modebar/manage.js | 1 - test/jasmine/tests/modebar_test.js | 9 ++++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/modebar/manage.js b/src/components/modebar/manage.js index 2f3586b85b6..82e4912f77b 100644 --- a/src/components/modebar/manage.js +++ b/src/components/modebar/manage.js @@ -246,7 +246,6 @@ function getButtonGroups(gd) { enableHover('hoverClosestGl2d'); enableHover('hoverClosestPie'); } else if(b === 'v1hovermode') { - enableHover('toggleHover'); enableHover('hoverClosestCartesian'); enableHover('hoverCompareCartesian'); enableHover('hoverClosestGeo'); diff --git a/test/jasmine/tests/modebar_test.js b/test/jasmine/tests/modebar_test.js index dc271a818a7..7e318cd975c 100644 --- a/test/jasmine/tests/modebar_test.js +++ b/test/jasmine/tests/modebar_test.js @@ -1642,7 +1642,7 @@ describe('ModeBar', function() { ]); }) .then(function() { - expect(countButtons()).toBe(initial + 4, 'skip duplicates'); + expect(countButtons()).toBe(initial + 5, 'skip duplicates'); return Plotly.relayout(gd, 'modebar.add', [ 'drawline', @@ -1656,6 +1656,13 @@ describe('ModeBar', function() { }) .then(function() { expect(countButtons()).toBe(initial); + + return Plotly.relayout(gd, 'modebar.add', [ + 'togglehover' + ]); + }) + .then(function() { + expect(countButtons()).toBe(initial + 1, 'add togglehover'); }) .then(done, done.fail); });