From 389b211d635c091211a3076c77ed0c6b3d69aac3 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Fri, 21 Jul 2023 12:01:06 -0400 Subject: [PATCH 1/3] add Plotly.eraseActiveShape command --- src/plot_api/index.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plot_api/index.js b/src/plot_api/index.js index 20ba695915e..3ac096fa444 100644 --- a/src/plot_api/index.js +++ b/src/plot_api/index.js @@ -24,6 +24,8 @@ exports.deleteFrames = main.deleteFrames; exports.animate = main.animate; exports.setPlotConfig = main.setPlotConfig; +exports.eraseActiveShape = require('../components/shapes/draw').eraseActiveShape; + exports.toImage = require('./to_image'); exports.validate = require('./validate'); exports.downloadImage = require('../snapshot/download'); From acc317f792e25c974c7eb458828060847c8221cd Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Mon, 24 Jul 2023 15:49:35 -0400 Subject: [PATCH 2/3] function wrap, rename and return --- src/components/shapes/draw.js | 2 +- src/plot_api/index.js | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/components/shapes/draw.js b/src/components/shapes/draw.js index 5f358145f93..a6465fc6b0a 100644 --- a/src/components/shapes/draw.js +++ b/src/components/shapes/draw.js @@ -669,7 +669,7 @@ function eraseActiveShape(gd) { delete gd._fullLayout._activeShapeIndex; - Registry.call('_guiRelayout', gd, { + return Registry.call('_guiRelayout', gd, { shapes: list }); } diff --git a/src/plot_api/index.js b/src/plot_api/index.js index 3ac096fa444..011ff30ba1c 100644 --- a/src/plot_api/index.js +++ b/src/plot_api/index.js @@ -24,7 +24,11 @@ exports.deleteFrames = main.deleteFrames; exports.animate = main.animate; exports.setPlotConfig = main.setPlotConfig; -exports.eraseActiveShape = require('../components/shapes/draw').eraseActiveShape; +var getGraphDiv = require('../lib/dom').getGraphDiv; +var eraseActiveShape = require('../components/shapes/draw').eraseActiveShape; +exports.deleteActiveShape = function(gd) { + return eraseActiveShape(getGraphDiv(gd)); +}; exports.toImage = require('./to_image'); exports.validate = require('./validate'); From 5c9a7c9fb33288a59198017aff5195bab3e73c3c Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Mon, 24 Jul 2023 15:50:46 -0400 Subject: [PATCH 3/3] draftlog --- draftlogs/6679_add.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/6679_add.md diff --git a/draftlogs/6679_add.md b/draftlogs/6679_add.md new file mode 100644 index 00000000000..84155131129 --- /dev/null +++ b/draftlogs/6679_add.md @@ -0,0 +1 @@ + - add Plotly.deleteActiveShape command [[#6679](https://github.com/plotly/plotly.js/pull/6679)]