From daa5b7be575eee54b0b1b4c6108bd9e6147da407 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Tue, 20 Jun 2023 13:26:12 -0400 Subject: [PATCH] do not run stamen-watercolor tests on CI for now --- test/image/compare_pixels_test.js | 11 +++++++++-- test/image/export_test.js | 2 +- test/image/make_baseline.py | 1 + test/image/make_exports.py | 2 +- test/jasmine/tests/mapbox_test.js | 2 +- 5 files changed, 13 insertions(+), 5 deletions(-) diff --git a/test/image/compare_pixels_test.js b/test/image/compare_pixels_test.js index 2d89c3ec09e..9640a73b004 100644 --- a/test/image/compare_pixels_test.js +++ b/test/image/compare_pixels_test.js @@ -56,8 +56,15 @@ argv._.forEach(function(pattern) { } }); -// skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610 -allMockList = allMockList.filter(function(a) { return a !== 'mapbox_custom-style';}); +allMockList = allMockList.filter(function(a) { + return ( + // used to pass before 2023 Jun 20 + a !== 'mapbox_stamen-style' && + + // skip for now | TODO: figure out why needed this in https://github.com/plotly/plotly.js/pull/6610 + a !== 'mapbox_custom-style' + ); +}); if(mathjax3) { allMockList = [ diff --git a/test/image/export_test.js b/test/image/export_test.js index 3fb1c90cf57..50e6d617df6 100644 --- a/test/image/export_test.js +++ b/test/image/export_test.js @@ -26,7 +26,7 @@ var DEFAULT_LIST = [ 'image_astronaut_source', 'gl2d_no-clustering2', 'gl3d_surface-heatmap-treemap_transparent-colorscale', - 'mapbox_stamen-style', + 'mapbox_density-multiple_legend', 'smith_modes', 'zsmooth_methods', 'fonts', diff --git a/test/image/make_baseline.py b/test/image/make_baseline.py index ef031a46e64..43fa4d39334 100644 --- a/test/image/make_baseline.py +++ b/test/image/make_baseline.py @@ -78,6 +78,7 @@ blacklist = [ 'mapbox_density0-legend', 'mapbox_osm-style', + 'mapbox_stamen-style', # used to pass before 2023 Jun 20 'mapbox_custom-style' # Figure out why needed this in https://github.com/plotly/plotly.js/pull/6610 ] allNames = [a for a in allNames if a not in blacklist] diff --git a/test/image/make_exports.py b/test/image/make_exports.py index 0e7ccd604db..e00fd79bdf1 100644 --- a/test/image/make_exports.py +++ b/test/image/make_exports.py @@ -27,7 +27,7 @@ 'image_astronaut_source', 'gl2d_no-clustering2', 'gl3d_surface-heatmap-treemap_transparent-colorscale', - 'mapbox_stamen-style', + 'mapbox_density-multiple_legend', 'smith_modes', 'zsmooth_methods', 'fonts', diff --git a/test/jasmine/tests/mapbox_test.js b/test/jasmine/tests/mapbox_test.js index 16804d4843f..46e647b294f 100644 --- a/test/jasmine/tests/mapbox_test.js +++ b/test/jasmine/tests/mapbox_test.js @@ -1513,7 +1513,7 @@ describe('mapbox plots', function() { }); }); - it('@gl should be displayed for style "stamen-watercolor"', function(done) { + it('@noCI @gl should be displayed for style "stamen-watercolor"', function(done) { Plotly.newPlot(gd, [{type: 'scattermapbox'}], {mapbox: {style: 'stamen-watercolor'}}) .then(function() { var s = d3SelectAll('.mapboxgl-ctrl-attrib');